[css-grid] Simplify the interface of GridResolvedPosition

third_party/WebKit/Source/core/style/GridPosition.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 
 namespace blink {
 
 enum GridPositionType {
     AutoPosition,
     ExplicitPosition, // [ <integer> || <string> ]
     SpanPosition, // span && [ <integer> || <string> ]
     NamedGridAreaPosition // <ident>
 };
 
+enum GridPositionSide {
+    ColumnStartSide,
+    ColumnEndSide,
+    RowStartSide,
+    RowEndSide
+};
+

[Manuel Rego, 2015/11/10 09:08:03]

Why are you moving the enum it's mostly used in GridResolvedPosition?

[svillar, 2015/11/10 10:56:37]

Definitions do not belong to the place they're used :)

IMHO this is a better place for it, it's something that belongs to GridPosition
semantics not GridResolvedPosition's.

 class GridPosition {
     DISALLOW_NEW();
 public:
     GridPosition()
         : m_type(AutoPosition)
         , m_integerPosition(0)
     {
     }
 
     bool isPositive() const { return integerPosition() > 0; }
@@ skipping 61 matching lines @@
     }
 private:
     GridPositionType m_type;
     int m_integerPosition;
     String m_namedGridLine;
 };
 
 } // namespace blink
 
 #endif // GridPosition_h