Don't set bogus height on new fragmentainer groups initially.

Don't set bogus height on new fragmentainer groups initially.

This essentially made it impossible to support more than two column rows in
auto-height multicol containers.

When a new fragmentainer group is created, resetColumnHeight() is called right
*before* the fragmentainer group is inserted into the array, so we'd trick
ourselves into believing that height always was non-auto, because the
heightIsAuto() method on MultiColumnFragmentainerGroup would require the
fragmentainer group to be the last one in the array to count as auto.

We could fix the order in which things are done, or just make the whole thing a
bit more robust, which this CL aims to do.

BUG=447718
R=leviw@chromium.org

Committed: https://crrev.com/a0c1edf2467002afb124b7ec61edde2a47d4b385
Cr-Commit-Position: refs/heads/master@{#360540}

[mstensho (USE GERRIT), 2015-11-05 12:53:44]

leviw, can you take a look, please?

[mstensho (USE GERRIT), 2015-11-05 13:35:21]

On 2015/11/05 12:53:44, mstensho wrote:
> leviw, can you take a look, please?

Oh.. that rebase had some interesting effects. Now
LayoutTests/fast/html/layout-runs-and-floats-crash.html is crashing with this
patch.

[mstensho (USE GERRIT), 2015-11-05 16:31:04]

On 2015/11/05 13:35:21, mstensho wrote:
> On 2015/11/05 12:53:44, mstensho wrote:
> > leviw, can you take a look, please?
> 
> Oh.. that rebase had some interesting effects. Now
> LayoutTests/fast/html/layout-runs-and-floats-crash.html is crashing with this
> patch.

Moving this one off your lawn for now (closing). I don't really think the patch
itself is to blame for this regression, but we obviously need to get the
underlying problem fixed before landing this one.

[mstensho (USE GERRIT), 2015-11-18 21:02:45]

Description was changed from

==========
Don't set bogus height on new fragmentainer groups initially.

This essentially made it impossible to support more than two column rows in
auto-height multicol containers.

When a new fragmentainer group is created, resetColumnHeight() is called right
*before* the fragmentainer group is inserted into the array, so we'd trick
ourselves into believing that height always was non-auto, because the
heightIsAuto() method on MultiColumnFragmentainerGroup would require the
fragmentainer group to be the last one in the array to count as auto.

We could fix the order in which things are done, or just make the whole thing a
bit more robust, which this CL aims to do.

BUG=447718
R=leviw@chromium.org
==========

to

==========
Don't set bogus height on new fragmentainer groups initially.

This essentially made it impossible to support more than two column rows in
auto-height multicol containers.

When a new fragmentainer group is created, resetColumnHeight() is called right
*before* the fragmentainer group is inserted into the array, so we'd trick
ourselves into believing that height always was non-auto, because the
heightIsAuto() method on MultiColumnFragmentainerGroup would require the
fragmentainer group to be the last one in the array to count as auto.

We could fix the order in which things are done, or just make the whole thing a
bit more robust, which this CL aims to do.

BUG=447718
R=leviw@chromium.org
==========

[mstensho (USE GERRIT), 2015-11-18 21:08:55]

@leviw: Reopening this. It should no longer cause the aforementioned regression.
Please take a look.

[leviw_travelin_and_unemployed, 2015-11-18 21:19:44]

lgtm

[mstensho (USE GERRIT), 2015-11-18 21:27:34]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-11-18 21:28:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424913003/40001

[commit-bot: I haz the power, 2015-11-18 22:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 22:17:45]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mstensho (USE GERRIT), 2015-11-18 22:21:15]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-11-18 22:22:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424913003/40001

[commit-bot: I haz the power, 2015-11-19 00:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 00:54:46]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mstensho (USE GERRIT), 2015-11-19 06:18:58]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-11-19 06:19:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424913003/40001

[commit-bot: I haz the power, 2015-11-19 07:02:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-19 07:03:51]

Patchset 3 (id:??) landed as
https://crrev.com/a0c1edf2467002afb124b7ec61edde2a47d4b385
Cr-Commit-Position: refs/heads/master@{#360540}