Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1424863005: Handle MOV (immediate) and MOVT to load ARM global addresses. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix movw and movt Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceAssemblerARM32.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.h
diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h
index 175bb3670959128efc15cda0d1e6e32f6818a375..1f8fe59939d84a7a314604e10dd254f36ed6dac1 100644
--- a/src/DartARM32/assembler_arm.h
+++ b/src/DartARM32/assembler_arm.h
@@ -1069,10 +1069,14 @@ class Assembler : public ValueObject {
bool use_far_branches_;
+#if 0
// If you are thinking of using one or both of these instructions directly,
// instead LoadImmediate should probably be used.
+ // Moved to ARM::AssemblerARM32::movw
void movw(Register rd, uint16_t imm16, Condition cond = AL);
+ // Moved to ARM::AssemblerARM32::movt
void movt(Register rd, uint16_t imm16, Condition cond = AL);
+#endif
void BindARMv6(Label* label);
void BindARMv7(Label* label);
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceAssemblerARM32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698