src/messages.h - Issue 1424823005: Reland of Check that array length stays a safe integer in Array.prototype.push

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.h

Issue 1424823005: Reland of Check that array length stays a safe integer in Array.prototype.push (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.h

diff --git a/src/messages.h b/src/messages.h

index c97204bbab329623edd37e1a497546a56eea6646..83413e8be71590dfa3622bb9cc36c9172411cd60 100644

--- a/src/messages.h

+++ b/src/messages.h

@@ -326,6 +326,9 @@

T(NoCatchOrFinally, "Missing catch or finally after try") \

T(NotIsvar, "builtin %%IS_VAR: not a variable") \

T(ParamAfterRest, "Rest parameter must be last formal parameter") \

+ T(PushPastSafeLength, \

+ "Pushing % elements on an array-like of length % " \

+ "is disallowed, as the total surpasses 2**53-1") \

T(BadSetterRestParameter, \

"Setter function argument must not be a rest parameter") \

T(ParamDupe, "Duplicate parameter name not allowed in this context") \

« no previous file with comments | « src/js/array.js ('k') | test/mjsunit/harmony/array-length.js » ('j') | no next file with comments »