Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1424783004: Revert of Add PassPaintVisualRectToCompositor feature flag. (Closed)

Created:
5 years, 1 month ago by perkj_chrome
Modified:
5 years, 1 month ago
Reviewers:
chrishtr, pdr., wkorman, vmpstr
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add PassPaintVisualRectToCompositor feature flag. (patchset #3 id:40001 of https://codereview.chromium.org/1410573008/ ) Reason for revert: Tentative revert since it seems to break http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31016. cc_unittests ThreadedChannelTestCommit.RunMultiThread_DirectRenderer. Original issue's description: > Add PassPaintVisualRectToCompositor feature flag. > > BUG=529938 > > Committed: https://crrev.com/e8cc107c99f8dea17c02c677270e4e8af3f943c7 > Cr-Commit-Position: refs/heads/master@{#357052} TBR=chrishtr@chromium.org,pdr@chromium.org,vmpstr@chromium.org,wkorman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=529938 Committed: https://crrev.com/31fc911d634e465b22687e78195a494e5e62225c Cr-Commit-Position: refs/heads/master@{#357072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
perkj_chrome
Created Revert of Add PassPaintVisualRectToCompositor feature flag.
5 years, 1 month ago (2015-10-30 10:17:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424783004/1
5 years, 1 month ago (2015-10-30 10:18:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 10:19:04 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31fc911d634e465b22687e78195a494e5e62225c Cr-Commit-Position: refs/heads/master@{#357072}
5 years, 1 month ago (2015-10-30 10:19:48 UTC) #4
perkj_chrome
5 years, 1 month ago (2015-10-30 11:02:56 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1421873004/ by perkj@chromium.org.

The reason for reverting is: Reverting the revert. 
It turns out ThreadedChannelTestCommit.RunMultiThread_DirectRenderer is flaky
and have flaked before this cl.
Sorry for reverting and reverting the revert..

Powered by Google App Engine
This is Rietveld 408576698