Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1424783002: Avoid compilation errors when the dart_target_arch is TARGET_ARCH_ARM (Closed)

Created:
5 years, 1 month ago by Chinmay
Modified:
5 years, 1 month ago
Reviewers:
cutchccutchan, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid compilation errors when the dart_target_arch is TARGET_ARCH_ARM R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/52d8128b4e91d594baae12698903fbc29ab6ba88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/vm/assembler_arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/cpu_arm.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Chinmay
5 years, 1 month ago (2015-10-26 22:28:38 UTC) #2
rmacnak
lgtm
5 years, 1 month ago (2015-10-26 22:37:53 UTC) #3
Chinmay
5 years, 1 month ago (2015-10-26 22:39:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52d8128b4e91d594baae12698903fbc29ab6ba88.

Powered by Google App Engine
This is Rietveld 408576698