Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1424743009: Switch autofill card saving bubble icon (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
Reviewers:
bondd, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch autofill card saving bubble icon BUG=505953 Committed: https://crrev.com/da39faa4d101833cd7eb2ec5bb1539872b2c4172 Cr-Commit-Position: refs/heads/master@{#358749}

Patch Set 1 #

Patch Set 2 : new grid #

Patch Set 3 : owners for gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M chrome/browser/ui/views/autofill/save_card_icon_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/vector_icons/credit_card.icon View 1 1 chunk +28 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/credit_card.1x.icon View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Evan Stade
5 years, 1 month ago (2015-11-09 19:43:51 UTC) #2
Evan Stade
+sky for OWNERS review of ui/gfx/BUILD.gn (and ui/gfx/OWNERS so this will be the last time ...
5 years, 1 month ago (2015-11-09 19:45:01 UTC) #4
bondd
lgtm
5 years, 1 month ago (2015-11-09 19:53:54 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424743009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424743009/40001
5 years, 1 month ago (2015-11-09 19:54:11 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 20:40:09 UTC) #10
sky
LGTM
5 years, 1 month ago (2015-11-10 00:49:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424743009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424743009/40001
5 years, 1 month ago (2015-11-10 00:58:03 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 02:01:36 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 02:02:16 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/da39faa4d101833cd7eb2ec5bb1539872b2c4172
Cr-Commit-Position: refs/heads/master@{#358749}

Powered by Google App Engine
This is Rietveld 408576698