Chromium Code Reviews| Index: fpdfsdk/src/fpdfformfill_embeddertest.cpp |
| diff --git a/fpdfsdk/src/fpdfformfill_embeddertest.cpp b/fpdfsdk/src/fpdfformfill_embeddertest.cpp |
| index 56710b9f8369e9bbbcefc349e51e63cfb436d184..fb669cdc16d51ad602f26fb69f99b23da2e8f12b 100644 |
| --- a/fpdfsdk/src/fpdfformfill_embeddertest.cpp |
| +++ b/fpdfsdk/src/fpdfformfill_embeddertest.cpp |
| @@ -6,6 +6,7 @@ |
| #include "../../testing/embedder_test.h" |
| #include "../../testing/embedder_test_mock_delegate.h" |
| #include "../../testing/embedder_test_timer_handling_delegate.h" |
| +#include "../../testing/test_support.h" |
| #include "testing/gmock/include/gmock/gmock.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| @@ -63,3 +64,27 @@ TEST_F(FPDFFormFillEmbeddertest, BUG_514690) { |
| UnloadPage(page); |
| } |
| + |
| +TEST_F(FPDFFormFillEmbeddertest, BUG_551248) { |
| + EmbedderTestTimerHandlingDelegate delegate; |
| + SetDelegate(&delegate); |
| + |
| + EXPECT_TRUE(OpenDocument("testing/resources/bug_551248.pdf")); |
| + FPDF_PAGE page = LoadPage(0); |
| + EXPECT_NE(nullptr, page); |
| + DoOpenActions(); |
| + delegate.AdvanceTime(5000); |
| + UnloadPage(page); |
| + |
| + const auto& alerts = delegate.GetAlerts(); |
| + ASSERT_EQ(1U, alerts.size()); |
| + |
| + wchar_t* message = GetWideString(alerts[0].message); |
|
dsinclair
2015/11/04 14:15:07
FX_WCHAR?
Lei Zhang
2015/11/04 22:11:29
Nope, see same comment in other file.
|
| + wchar_t* title = GetWideString(alerts[0].title); |
|
dsinclair
2015/11/04 14:15:07
Can these go in a unique_ptr so they just get clea
Lei Zhang
2015/11/04 22:11:29
Went with std::wstring.
|
| + EXPECT_STREQ(L"hello chamal", message); |
|
Tom Sepez
2015/11/04 18:02:33
nit: we might want to sanitize chamal's identity.
Lei Zhang
2015/11/04 22:11:29
But hello world is so boring. The bug is public, *
|
| + EXPECT_STREQ(L"Alert", title); |
| + EXPECT_EQ(0, alerts[0].type); |
| + EXPECT_EQ(0, alerts[0].icon); |
| + free(message); |
| + free(title); |
| +} |