[turbofan] Improve deferred code handling for polymorphic property access.

[turbofan] Improve deferred code handling for polymorphic property access.

Only mark the last fallthrough control as deferred, otherwise the
splintering will ruin the code generation for the (maybe likely)
polymorphic cases.

Drive-by-fix: Reduce overall code duplication between JSLoadNamed
and JSStoreNamed specialization.

R=jarin@chromium.org
BUG=v8:4470
LOG=n

Committed: https://crrev.com/22b9ec0bcdc22489d93cc66e29dfa3603bf1baa4
Cr-Commit-Position: refs/heads/master@{#31623}

[Benedikt Meurer, 2015-10-26 15:56:23]

Hey Jaro,

Some small optimization.
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2015-10-26 16:05:45]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 16:05:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424733002/1

[commit-bot: I haz the power, 2015-10-26 17:10:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 17:10:12]

Dry run: This issue passed the CQ dry run.

[Jarin, 2015-10-26 21:14:50]

https://codereview.chromium.org/1424733002/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/1424733002/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.cc:843: // Collect the fallthru
control as final "exit" control.
Why the funny spelling of fallthru? (Also in other places)

How about replacing copy&paste-fu with a separate-function-fu?

[Benedikt Meurer, 2015-10-28 10:20:50]

Refactored to reduce overall code duplication.
Please take another look.

https://codereview.chromium.org/1424733002/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/1424733002/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.cc:843: // Collect the fallthru
control as final "exit" control.
Done. Refactored the whole thing into a single named access reduce method.

[Benedikt Meurer, 2015-10-28 10:21:22]

Description was changed from

==========
[turbofan] Improve deferred code handling for polymorphic property access.

Only mark the last fallthrough control as deferred, otherwise the
splintering will ruin the code generation for the (maybe likely)
polymorphic cases.

R=jarin@chromium.org
BUG=v8:4470
LOG=n
==========

to

==========
[turbofan] Improve deferred code handling for polymorphic property access.

Only mark the last fallthrough control as deferred, otherwise the
splintering will ruin the code generation for the (maybe likely)
polymorphic cases.

Drive-by-fix: Reduce overall code duplication between JSLoadNamed
and JSStoreNamed specialization.

R=jarin@chromium.org
BUG=v8:4470
LOG=n
==========

[Jarin, 2015-10-28 10:25:52]

lgtm

[Benedikt Meurer, 2015-10-28 10:26:04]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-10-28 10:26:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424733002/40001

[commit-bot: I haz the power, 2015-10-28 11:00:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-28 11:01:28]

Patchset 3 (id:??) landed as
https://crrev.com/22b9ec0bcdc22489d93cc66e29dfa3603bf1baa4
Cr-Commit-Position: refs/heads/master@{#31623}