Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1424713008: win: Fix build after 2eeaa3ac549a (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M handler/main.cc View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
Committed patchset #1 (id:1) manually as 827e045279e15429ac5753e3e97ad2c0d53dc84a (presubmit successful).
5 years, 1 month ago (2015-11-05 19:06:22 UTC) #1
Mark Mentovai
TBR
5 years, 1 month ago (2015-11-05 19:06:36 UTC) #3
scottmg
Compiling is so overrated! lgtm https://codereview.chromium.org/1424713008/diff/1/handler/main.cc File handler/main.cc (right): https://codereview.chromium.org/1424713008/diff/1/handler/main.cc#newcode189 handler/main.cc:189: (options.handshake_handle = IntToHandle(handle_uint)) == ...
5 years, 1 month ago (2015-11-05 19:08:17 UTC) #4
Mark Mentovai
5 years, 1 month ago (2015-11-05 19:09:33 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1424713008/diff/1/handler/main.cc
File handler/main.cc (right):

https://codereview.chromium.org/1424713008/diff/1/handler/main.cc#newcode189
handler/main.cc:189: (options.handshake_handle = IntToHandle(handle_uint)) ==
scottmg wrote:
> (Doesn't this assignment cause a warning?)

It would if there wasn’t an == on there, but the == keeps the assignment from
ever “leaking” out to being evaluated in boolean context.

Powered by Google App Engine
This is Rietveld 408576698