Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 14247037: Remove the COMPILER(RVCT) guard. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 8 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the COMPILER(RVCT) guard. RVCT is not supported by blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149123

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -39 lines) Patch
M Source/wtf/Alignment.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Assertions.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Compiler.h View 7 chunks +5 lines, -17 lines 0 comments Download
M Source/wtf/Platform.h View 1 4 chunks +2 lines, -18 lines 0 comments Download
M Source/wtf/UnusedParam.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (0 generated)
lgombos
Cleanup.
7 years, 8 months ago (2013-04-20 05:19:57 UTC) #1
abarth-chromium
I'm not sure which compilers we use on ARM. Maybe Peter knows?
7 years, 8 months ago (2013-04-20 16:12:25 UTC) #2
lgombos
On 2013/04/20 16:12:25, abarth wrote: > I'm not sure which compilers we use on ARM. ...
7 years, 8 months ago (2013-04-20 19:44:32 UTC) #3
abarth-chromium
Android try job sent.
7 years, 8 months ago (2013-04-20 22:47:03 UTC) #4
Peter Beverloo
Android always uses GCC, so LGTM from our point of view. Adam (or another OWNER) ...
7 years, 8 months ago (2013-04-22 13:34:55 UTC) #5
abarth-chromium
lgtm LGTM
7 years, 8 months ago (2013-04-22 16:49:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/1
7 years, 8 months ago (2013-04-22 16:49:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4807
7 years, 8 months ago (2013-04-22 17:23:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/1
7 years, 8 months ago (2013-04-22 18:20:23 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4832
7 years, 8 months ago (2013-04-22 19:09:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-22 22:12:35 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4903
7 years, 8 months ago (2013-04-22 22:45:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-22 22:50:53 UTC) #13
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=2916
7 years, 8 months ago (2013-04-22 23:16:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-23 00:11:23 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-23 00:21:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-23 01:48:00 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4941
7 years, 8 months ago (2013-04-23 02:14:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-23 03:59:45 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4969
7 years, 8 months ago (2013-04-23 04:35:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-25 05:37:04 UTC) #21
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-25 05:53:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-25 14:24:52 UTC) #23
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5438
7 years, 8 months ago (2013-04-25 14:52:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-25 14:54:28 UTC) #25
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5445
7 years, 8 months ago (2013-04-25 15:20:18 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-25 17:04:06 UTC) #27
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-25 17:06:54 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247037/20001
7 years, 8 months ago (2013-04-25 19:03:17 UTC) #29
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 19:29:16 UTC) #30
Message was sent while issue was closed.
Change committed as 149123

Powered by Google App Engine
This is Rietveld 408576698