Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 14247036: Remove USE(ZLIB) guard. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 8 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove USE(ZLIB) guard. It is not longer used as it is always turned on for blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148783

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -44 lines) Patch
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketDeflateFramer.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/modules/websockets/WebSocketDeflateFramer.cpp View 7 chunks +0 lines, -28 lines 0 comments Download
M Source/modules/websockets/WebSocketDeflater.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/wtf/Platform.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
lgombos
Cleanup. USE(ZLIB) was turned off only for PLATFORM(QT) which is not supported for blink.
7 years, 8 months ago (2013-04-20 03:07:48 UTC) #1
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-20 05:42:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247036/1
7 years, 8 months ago (2013-04-20 05:42:58 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4639
7 years, 8 months ago (2013-04-20 06:19:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247036/1
7 years, 8 months ago (2013-04-20 12:49:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4650
7 years, 8 months ago (2013-04-20 12:59:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247036/1
7 years, 8 months ago (2013-04-20 14:35:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4658
7 years, 8 months ago (2013-04-20 15:11:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247036/1
7 years, 8 months ago (2013-04-20 15:17:46 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4661
7 years, 8 months ago (2013-04-20 15:26:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247036/1
7 years, 8 months ago (2013-04-20 15:51:27 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4669
7 years, 8 months ago (2013-04-20 16:24:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247036/1
7 years, 8 months ago (2013-04-20 16:58:09 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4675
7 years, 8 months ago (2013-04-20 17:10:29 UTC) #14
abarth-chromium
apply_issue failed ^^^ Looks like you might need to rebase to master.
7 years, 8 months ago (2013-04-20 19:13:21 UTC) #15
lgombos
On 2013/04/20 19:13:21, abarth wrote: > apply_issue failed > > ^^^ Looks like you might ...
7 years, 8 months ago (2013-04-20 23:40:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14247036/22001
7 years, 8 months ago (2013-04-21 00:53:14 UTC) #17
commit-bot: I haz the power
7 years, 8 months ago (2013-04-21 01:17:34 UTC) #18
Message was sent while issue was closed.
Change committed as 148783

Powered by Google App Engine
This is Rietveld 408576698