Upon load failure, remove sync script from pending queue.

Upon load failure, remove sync script from pending queue.

If a script element is to be loaded synchronously and executed in order,
it's queued for execution before loading. Should that load fail, the
immediate execution of the script,

  https://html.spec.whatwg.org/#execute-the-script-block

should only result in an error event being dispatched.

Implementation-wise, along with signalling error, the failed script must also
be removed from the internal in-order pending execution queue. We're done with
(not) executing the script and failure to remove it will cause subsequent
processing of its pending queue to see the script as having failed
to load and re-dispatch an error event.

R=tkent
BUG=503077
Committed: https://crrev.com/c85e2da47823fc952467a67e5ce7b093382a505e
Cr-Commit-Position: refs/heads/master@{#357778}

[sof, 2015-11-03 20:31:14]

Description was changed from

==========
Upon load failure, remove sync script from execution queue.

If a script element is to be loaded synchronously and executed in order,
it's queued for execution before loading. Should that load fail, the
immediate execution of the script,

  https://html.spec.whatwg.org/#execute-the-script-block

should only result in an error event being dispatched.

Implementation-wise, along with signalling error, the failed script must also
be removed from the internal in-order execution queue. We're done with
(not) executing the script and failure to remove it will cause subsequent
processing of the script execution queue to see the script as having failed
to load and re-dispatch an error event.

R=
BUG=503077
==========

to

==========
Upon load failure, remove sync script from pending queue.

If a script element is to be loaded synchronously and executed in order,
it's queued for execution before loading. Should that load fail, the
immediate execution of the script,

  https://html.spec.whatwg.org/#execute-the-script-block

should only result in an error event being dispatched.

Implementation-wise, along with signalling error, the failed script must also
be removed from the internal in-order pending xecution queue. We're done with
(not) executing the script and failure to remove it will cause subsequent
processing of its pending queue to see the script as having failed
to load and re-dispatch an error event.

R=
BUG=503077
==========

[sof, 2015-11-03 20:48:30]

sigbjornf@opera.com changed reviewers:
+ japhet@chromium.org, tkent@chromium.org

[sof, 2015-11-03 20:48:31]

please take a look.

With the extra pending in-order queue manipulations simplified away by r356080,
a reland of  https://codereview.chromium.org/1263743002/ is in order.

[tkent, 2015-11-03 22:58:24]

lgtm

> be removed from the internal in-order pending xecution queue. We're done with

xecution -> execution

[sof, 2015-11-04 07:32:49]

Description was changed from

==========
Upon load failure, remove sync script from pending queue.

If a script element is to be loaded synchronously and executed in order,
it's queued for execution before loading. Should that load fail, the
immediate execution of the script,

  https://html.spec.whatwg.org/#execute-the-script-block

should only result in an error event being dispatched.

Implementation-wise, along with signalling error, the failed script must also
be removed from the internal in-order pending xecution queue. We're done with
(not) executing the script and failure to remove it will cause subsequent
processing of its pending queue to see the script as having failed
to load and re-dispatch an error event.

R=
BUG=503077
==========

to

==========
Upon load failure, remove sync script from pending queue.

If a script element is to be loaded synchronously and executed in order,
it's queued for execution before loading. Should that load fail, the
immediate execution of the script,

  https://html.spec.whatwg.org/#execute-the-script-block

should only result in an error event being dispatched.

Implementation-wise, along with signalling error, the failed script must also
be removed from the internal in-order pending execution queue. We're done with
(not) executing the script and failure to remove it will cause subsequent
processing of its pending queue to see the script as having failed
to load and re-dispatch an error event.

R=tkent
BUG=503077
==========

[sof, 2015-11-04 07:32:56]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-04 07:33:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703007/20001

[commit-bot: I haz the power, 2015-11-04 07:37:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-04 07:38:31]

Patchset 2 (id:??) landed as
https://crrev.com/c85e2da47823fc952467a67e5ce7b093382a505e
Cr-Commit-Position: refs/heads/master@{#357778}