Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/objects-debug.cc

Issue 1424703005: Remove JSBuiltinsObject. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.h ('K') | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index fa406b39d795f80d6ced81f3674cef7e94081c1d..17220c6db77594ec556943b06a629eb8e0b8600a 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -119,9 +119,6 @@ void HeapObject::HeapObjectVerify() {
case JS_GLOBAL_OBJECT_TYPE:
JSGlobalObject::cast(this)->JSGlobalObjectVerify();
break;
- case JS_BUILTINS_OBJECT_TYPE:
- JSBuiltinsObject::cast(this)->JSBuiltinsObjectVerify();
- break;
case CELL_TYPE:
Cell::cast(this)->CellVerify();
break;
@@ -570,20 +567,13 @@ void JSGlobalProxy::JSGlobalProxyVerify() {
void JSGlobalObject::JSGlobalObjectVerify() {
CHECK(IsJSGlobalObject());
- JSObjectVerify();
- for (int i = GlobalObject::kBuiltinsOffset;
- i < JSGlobalObject::kSize;
- i += kPointerSize) {
- VerifyObjectField(i);
+ // Do not check the dummy global object for the builtins.
+ if (GlobalDictionary::cast(properties())->NumberOfElements() == 0 &&
+ elements()->length() == 0) {
+ return;
}
-}
-
-
-void JSBuiltinsObject::JSBuiltinsObjectVerify() {
- CHECK(IsJSBuiltinsObject());
JSObjectVerify();
- for (int i = GlobalObject::kBuiltinsOffset;
- i < JSBuiltinsObject::kSize;
+ for (int i = GlobalObject::kHeaderSize; i < JSGlobalObject::kSize;
i += kPointerSize) {
VerifyObjectField(i);
}
« src/objects.h ('K') | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698