Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: runtime/vm/debugger.h

Issue 1424703004: Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix build Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.h
diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h
index 7c6a7b7138926ebb13ec6b825ad8bce47db6538c..b257a821043f4ef6becfa1551883ed8d037f3182 100644
--- a/runtime/vm/debugger.h
+++ b/runtime/vm/debugger.h
@@ -515,7 +515,9 @@ class Debugger {
// Returns true if there is at least one breakpoint set in func or code.
// Checks for both user-defined and internal temporary breakpoints.
- bool HasBreakpoint(const Function& func);
+ // This may be called from different threads, therefore do not use the,
+ // debugger's zone.
+ bool HasBreakpoint(const Function& func, Zone* zone);
bool HasBreakpoint(const Code& code);
// Returns true if the call at address pc is patched to point to
@@ -650,10 +652,6 @@ class Debugger {
void HandleSteppingRequest(DebuggerStackTrace* stack_trace);
- Zone* zone() const {
- return isolate_->current_zone();
- }
-
Isolate* isolate_;
Dart_Port isolate_id_; // A unique ID for the isolate in the debugger.
bool initialized_;
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698