runtime/lib/vmservice.cc - Issue 1424703004: Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/vmservice.cc

Issue 1424703004: Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix build Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/vmservice.cc

diff --git a/runtime/lib/vmservice.cc b/runtime/lib/vmservice.cc

index 34799456da72cb11b4fcb5f18a06e7d1ae642917..12aadb6831defc8db65c49e9f90837b32d061727 100644

--- a/runtime/lib/vmservice.cc

+++ b/runtime/lib/vmservice.cc

@@ -63,8 +63,8 @@ class RegisterRunningIsolatesVisitor : public IsolateVisitor {

args.SetAt(0, port_int);

args.SetAt(1, send_port);

args.SetAt(2, name);

- Object& r = Object::Handle(service_isolate_->current_zone());

- r = DartEntry::InvokeFunction(register_function_, args);

+ const Object& r = Object::Handle(

+ DartEntry::InvokeFunction(register_function_, args));

if (FLAG_trace_service) {

OS::Print("vm-service: Isolate %s %" Pd64 " registered.\n",

name.ToCString(),

« no previous file with comments | « runtime/lib/isolate.cc ('k') | runtime/vm/code_generator.cc » ('j') | no next file with comments »