Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2136)

Unified Diff: base/time/time_win.cc

Issue 1424703003: Kills TraceTicks, which was functionally the same as TimeTicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/time/time_win.cc
diff --git a/base/time/time_win.cc b/base/time/time_win.cc
index bc058040d0c7b5a23923383741bbc811713c6485..6022772615395273d75b68c1113286cf488ba80c 100644
--- a/base/time/time_win.cc
+++ b/base/time/time_win.cc
@@ -48,7 +48,6 @@ using base::ThreadTicks;
using base::Time;
using base::TimeDelta;
using base::TimeTicks;
-using base::TraceTicks;
namespace {
@@ -459,14 +458,6 @@ void InitializeNowFunctionPointer() {
//
// Otherwise, Now uses the high-resolution QPC clock. As of 21 August 2015,
// ~72% of users fall within this category.
- //
- // TraceTicks::Now() always uses the same clock as TimeTicks::Now(), even
- // when the QPC exists but is expensive or unreliable. This is because we'd
- // eventually like to merge TraceTicks and TimeTicks and have one type of
- // timestamp that is reliable, monotonic, and comparable. Also, while we could
- // use the high-resolution timer for TraceTicks even when it's unreliable or
- // slow, it's easier to make tracing tools accommodate a coarse timer than
- // one that's unreliable or slow.
NowFunction now_function;
base::CPU cpu;
if (ticks_per_sec.QuadPart <= 0 ||
@@ -612,9 +603,6 @@ double ThreadTicks::TSCTicksPerSecond() {
return tsc_ticks_per_second;
}
-// static
-TraceTicks TraceTicks::Now() {
- return TraceTicks() + g_now_function();
}
// static

Powered by Google App Engine
This is Rietveld 408576698