Kills TraceTicks, which was functionally the same as TimeTicks

Kills TraceTicks, which was functionally the same as TimeTicks

This was not true until last week's submission of
http://crrev.com/1374753004.

BUG=541692
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NO_PRESUBMIT=true

Committed: https://crrev.com/2bccc2cf38624593e1adafefccec7314aa573b0f
Cr-Commit-Position: refs/heads/master@{#358047}

[charliea (OOO until 10-5), 2015-10-29 19:20:41]

Patchset #1 (id:1) has been deleted

[charliea (OOO until 10-5), 2015-10-29 19:21:41]

charliea@chromium.org changed reviewers:
+ simonhatch@chromium.org

[sh, 2015-10-29 19:31:19]

On 2015/10/29 19:22:44, charliea wrote:

I haven't looked at this in much depth, but quick question: Is this mostly a
mechanical refactoring? Because
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
might apply.

[charliea (OOO until 10-5), 2015-10-29 21:19:27]

On 2015/10/29 19:31:19, sh wrote:
> On 2015/10/29 19:22:44, charliea wrote:
> 
> I haven't looked at this in much depth, but quick question: Is this mostly a
> mechanical refactoring? Because
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
> might apply.

Sounds good! I'll try to do as much as possible in separate CLs (like fixing
syscall_parameters_restrictions) and get LGTMs from the  remaining OWNERS where
the fix isn't a simple search and replace.

Could you still take a look at the base/trace_event changes?

[shatch, 2015-10-30 16:19:22]

base/trace_event
components/tracing
content/browser/tracing

lgtm

[charliea (OOO until 10-5), 2015-10-30 16:25:31]

charliea@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[charliea (OOO until 10-5), 2015-10-30 16:25:31]

+R:rmcilroy, +CC:skyostil

Could you take a look at the changes to
components/scheduler/child/idle_helper.[h,cc] to make sure they're alright?

[charliea (OOO until 10-5), 2015-10-30 16:37:50]

charliea@chromium.org changed reviewers:
+ thestig@chromium.org

[charliea (OOO until 10-5), 2015-10-30 16:37:50]

+R:thestig

Lei, could you take a look at the base/time changes?

[rmcilroy, 2015-10-30 17:09:22]

One nit, but otherwise idle_helper changes LGTM, thanks

https://codereview.chromium.org/1424703003/diff/40001/components/scheduler/ch...
File components/scheduler/child/idle_helper.h (right):

https://codereview.chromium.org/1424703003/diff/40001/components/scheduler/ch...
components/scheduler/child/idle_helper.h:162: base::TimeTicks
last_idle_task_time_;
Could you keep tracing in this variable name (e.g.,
last_idle_task_time_for_tracing_) since it should only be used in tracing code.

[Sami, 2015-10-30 17:11:30]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2015-10-30 17:11:31]

cc/scheduler lgtm.

[charliea (OOO until 10-5), 2015-10-30 17:32:29]

https://codereview.chromium.org/1424703003/diff/40001/components/scheduler/ch...
File components/scheduler/child/idle_helper.h (right):

https://codereview.chromium.org/1424703003/diff/40001/components/scheduler/ch...
components/scheduler/child/idle_helper.h:162: base::TimeTicks
last_idle_task_time_;
On 2015/10/30 17:09:22, rmcilroy wrote:
> Could you keep tracing in this variable name (e.g.,
> last_idle_task_time_for_tracing_) since it should only be used in tracing
code.

Done.

[Lei Zhang, 2015-11-02 23:20:11]

On 2015/10/30 16:37:50, charliea wrote:
> +R:thestig
> 
> Lei, could you take a look at the base/time changes?

LGTM! Happy to see one less time type.

[Lei Zhang, 2015-11-02 23:20:19]

https://codereview.chromium.org/1424703003/diff/60001/base/time/time.h
File base/time/time.h (right):

https://codereview.chromium.org/1424703003/diff/60001/base/time/time.h#newcode17
base/time/time.h:17: // incrementing, for use in measuring time durations. 
Internally, they are
nit: Don't bother with double spaces at the end of a sentence. It's also
inconsistent with the rest of the paragraph. I've written too much for just a
space.

[charliea (OOO until 10-5), 2015-11-02 23:22:49]

charliea@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2015-11-02 23:40:22]

lgtm

[charliea (OOO until 10-5), 2015-11-03 13:36:42]

charliea@chromium.org changed reviewers:
+ gab@chromium.org

[charliea (OOO until 10-5), 2015-11-03 13:36:43]

gab@, could you take a look for components/startup_metric_utils OWNERS?

https://codereview.chromium.org/1424703003/diff/60001/base/time/time.h
File base/time/time.h (right):

https://codereview.chromium.org/1424703003/diff/60001/base/time/time.h#newcode17
base/time/time.h:17: // incrementing, for use in measuring time durations. 
Internally, they are
On 2015/11/02 23:20:19, Lei Zhang wrote:
> nit: Don't bother with double spaces at the end of a sentence. It's also
> inconsistent with the rest of the paragraph. I've written too much for just a
> space.

Done.

[charliea (OOO until 10-5), 2015-11-03 13:39:03]

charliea@chromium.org changed reviewers:
+ sadrul@chromium.org

[charliea (OOO until 10-5), 2015-11-03 13:39:04]

sadrul@, could you take a look as a ui/events/latency_info.cc OWNER?

[charliea (OOO until 10-5), 2015-11-03 13:45:06]

charliea@chromium.org changed reviewers:
+ agl@chromium.org, raymes@chromium.org

[charliea (OOO until 10-5), 2015-11-03 13:45:07]

agl@, could you take a look as ipc/ipc_message_utils.[h,cc] OWNER?

raymes@, could you take a look as ppapi/shared_impl/ppb_trace_event_impl.cc
OWNER?

[gab, 2015-11-03 17:26:28]

Glad to this see this happening :-)

components/startup_metric_utils lgtm

[sadrul, 2015-11-03 17:29:13]

sadrul@chromium.org changed reviewers:
+ miletus@chromium.org

[sadrul, 2015-11-03 17:29:13]

+miletus@

The change in latency_info.cc looks good, but miletus@ would be a better
reviewer.

[agl, 2015-11-03 18:03:54]

ipc/ LGTM.

[Yufeng Shen (Slow to review), 2015-11-03 18:53:14]

latency_info lgtm

[charliea (OOO until 10-5), 2015-11-03 19:15:34]

Description was changed from

==========
Kills TraceTicks, which was functionally the same as TimeTicks

This was not true until last week's submission of
http://crrev.com/1374753004.

BUG=541692
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Kills TraceTicks, which was functionally the same as TimeTicks

This was not true until last week's submission of
http://crrev.com/1374753004.

BUG=541692
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[charliea (OOO until 10-5), 2015-11-03 19:15:34]

charliea@chromium.org changed reviewers:
- sadrul@chromium.org

[charliea (OOO until 10-5), 2015-11-03 19:18:16]

charliea@chromium.org changed reviewers:
+ bbudge@chromium.org
- raymes@chromium.org

[charliea (OOO until 10-5), 2015-11-03 19:18:16]

bbudge@, could you take a look as ppapi/shared_impl/ppb_trace_event_impl.cc
OWNER?

[bbudge, 2015-11-03 19:20:58]

ppapi lgtm

[charliea (OOO until 10-5), 2015-11-03 19:21:38]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2015-11-03 19:21:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
simonhatch@chromium.org, skyostil@chromium.org, rmcilroy@chromium.org,
thestig@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1424703003/#ps80001
(title: "Code review")

[commit-bot: I haz the power, 2015-11-03 19:23:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703003/80001

[commit-bot: I haz the power, 2015-11-03 19:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 19:27:32]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[charliea (OOO until 10-5), 2015-11-03 20:01:01]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2015-11-03 20:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
skyostil@chromium.org, thestig@chromium.org, gab@chromium.org,
simonhatch@chromium.org, rmcilroy@chromium.org, sievers@chromium.org,
miletus@chromium.org, agl@chromium.org
Link to the patchset: https://codereview.chromium.org/1424703003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-11-03 20:02:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703003/100001

[commit-bot: I haz the power, 2015-11-03 20:21:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 20:21:47]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[charliea (OOO until 10-5), 2015-11-03 20:28:02]

charliea@chromium.org changed reviewers:
+ dcheng@chromium.org

[charliea (OOO until 10-5), 2015-11-03 20:28:25]

On 2015/11/03 20:28:03, charliea wrote:

+dcheng for ipc_messages.h security review

[dcheng, 2015-11-03 20:55:22]

rs lgtm for ipc changes

[charliea (OOO until 10-5), 2015-11-03 22:02:01]

As discussed with dpranke on #chromium, I'm going to add NO_PRESUBMIT=true to
get around
https://code.google.com/p/chromium/issues/detail?id=551106&thanks=551106&ts=1...

[charliea (OOO until 10-5), 2015-11-03 22:02:23]

Description was changed from

==========
Kills TraceTicks, which was functionally the same as TimeTicks

This was not true until last week's submission of
http://crrev.com/1374753004.

BUG=541692
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Kills TraceTicks, which was functionally the same as TimeTicks

This was not true until last week's submission of
http://crrev.com/1374753004.

BUG=541692
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NO_PRESUBMIT=true
==========

[charliea (OOO until 10-5), 2015-11-03 22:02:29]

The CQ bit was checked by charliea@chromium.org

[commit-bot: I haz the power, 2015-11-03 22:04:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703003/100001

[commit-bot: I haz the power, 2015-11-03 22:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 22:18:10]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[charliea (OOO until 10-5), 2015-11-04 13:45:21]

There were two errors during submission: one new use of TraceTicks and one
existing use of TraceTicks::kClockSystemTrace, both of which caused compile
errors. I fixed the former and sent out
https://codereview.chromium.org/1423803003/ to fix the latter.

Hoping to have this in by the end of the day today.

[charliea (OOO until 10-5), 2015-11-04 19:54:51]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2015-11-04 19:54:52]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
skyostil@chromium.org, thestig@chromium.org, gab@chromium.org,
simonhatch@chromium.org, rmcilroy@chromium.org, dcheng@chromium.org,
miletus@chromium.org, agl@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1424703003/#ps120001
(title: "Synced to HEAD")

[commit-bot: I haz the power, 2015-11-04 19:56:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703003/120001

[commit-bot: I haz the power, 2015-11-04 20:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 20:11:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[charliea (OOO until 10-5), 2015-11-05 04:09:21]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2015-11-05 04:09:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
skyostil@chromium.org, thestig@chromium.org, gab@chromium.org,
simonhatch@chromium.org, rmcilroy@chromium.org, dcheng@chromium.org,
miletus@chromium.org, agl@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1424703003/#ps140001
(title: "Synced to HEAD")

[commit-bot: I haz the power, 2015-11-05 04:10:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703003/140001

[commit-bot: I haz the power, 2015-11-05 04:59:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 04:59:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[charliea (OOO until 10-5), 2015-11-05 12:12:37]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2015-11-05 12:12:37]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
skyostil@chromium.org, thestig@chromium.org, gab@chromium.org,
simonhatch@chromium.org, rmcilroy@chromium.org, dcheng@chromium.org,
miletus@chromium.org, agl@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1424703003/#ps160001
(title: "Fixed win compile error.")

[commit-bot: I haz the power, 2015-11-05 12:13:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703003/160001

[commit-bot: I haz the power, 2015-11-05 13:49:06]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2015-11-05 13:50:01]

Patchset 8 (id:??) landed as
https://crrev.com/2bccc2cf38624593e1adafefccec7314aa573b0f
Cr-Commit-Position: refs/heads/master@{#358047}