Disable SDK constraint checking on bleeding edge.

utils/tests/pub/version_solver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub_update_test;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:unittest/unittest.dart';
@@ skipping 593 matching lines @@
     'foo 4.0.0': {'bar': '4.0.0'},
     'bar 1.0.0': {'sdk': goodVersion },
     'bar 2.0.0': {'sdk': goodVersion },
     'bar 3.0.0': {'sdk': badVersion },
     'bar 4.0.0': {'sdk': badVersion }
   }, result: {
     'myapp from root': '0.0.0',
     'foo': '2.0.0',
     'bar': '2.0.0'
   }, maxTries: 3);
+
+  testResolve('ignores SDK constraints on bleeding edge', {
+    'myapp 0.0.0': {'sdk': badVersion }
+  }, result: {
+    'myapp from root': '0.0.0'
+  }, useBleedingEdgeSdkVersion: true);
 }
 
 testResolve(description, packages,
-            {lockfile, result, FailMatcherBuilder error, int maxTries}) {
+            {lockfile, result, FailMatcherBuilder error, int maxTries,
+             bool useBleedingEdgeSdkVersion}) {
   if (maxTries == null) maxTries = 1;
+  if (useBleedingEdgeSdkVersion == null) useBleedingEdgeSdkVersion = false;
 
   test(description, () {
     var cache = new SystemCache('.');
     source1 = new MockSource('mock1');
     source2 = new MockSource('mock2');
     cache.register(source1);
     cache.register(source2);
     cache.sources.setDefault(source1.name);
 
     // Build the test package graph.
@@ skipping 30 matching lines @@
 
     var realLockFile = new LockFile.empty();
     if (lockfile != null) {
       lockfile.forEach((name, version) {
         version = new Version.parse(version);
         realLockFile.packages[name] =
           new PackageId(name, source1, version, name);
       });
     }
 
+    // Make a version number like the continuous build's version.
+    var previousVersion = sdk.version;
+    if (useBleedingEdgeSdkVersion) {
+      sdk.version = new Version(0, 1, 2, build: '0_r12345_juser');
+    }
+
     // Resolve the versions.
     var future = resolveVersions(cache.sources, root,
         lockFile: realLockFile);
 
     var matcher;
     if (result != null) {
       matcher = new SolveSuccessMatcher(result, maxTries);
     } else if (error != null) {
       matcher = error(maxTries);
     }
 
+    future = future.whenComplete(() {
+      if (useBleedingEdgeSdkVersion) {
+        sdk.version = previousVersion;
+      }
+    });

[nweiz, 2013/04/19 18:42:07]

I would find it a little cleaner if you did this whenComplete inline in the
expect() call.

[Bob Nystrom, 2013/04/19 21:13:04]

I tried that, but it looked weird to me jammed in there. It's really clean up
code and not part of the expectation.

+
     expect(future, completion(matcher));
   });
 }
 
 typedef SolveFailMatcher FailMatcherBuilder(int maxTries);
 
 FailMatcherBuilder noVersion(List<String> packages) {
   return (maxTries) => new SolveFailMatcher(packages, maxTries,
       NoVersionException);
 }
@@ skipping 275 matching lines @@
   };
 
   var match = new RegExp(r"(.*) from (.*)").firstMatch(description);
   if (match != null) {
     name = match[1];
     source = sourceNames[match[2]];
   }
 
   callback(isDev, name, source);
 }