chrome/common/extensions/docs/server2/fake_fetchers.py - Issue 14247024: Devserver: allow SubversionFileSystem to be pinned to a specific rev on construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/fake_fetchers.py

Issue 14247024: Devserver: allow SubversionFileSystem to be pinned to a specific rev on construction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/cron_servlet_test.py ('k') | chrome/common/extensions/docs/server2/fake_url_fetcher.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/fake_fetchers.py

diff --git a/chrome/common/extensions/docs/server2/fake_fetchers.py b/chrome/common/extensions/docs/server2/fake_fetchers.py

index 3a6119250107b7bfd497072ebee99e42af709821..4e66e4aaed16817b9025efd323dcab7ac316d8f2 100644

--- a/chrome/common/extensions/docs/server2/fake_fetchers.py

+++ b/chrome/common/extensions/docs/server2/fake_fetchers.py

@@ -44,6 +44,7 @@ class FakeSubversionServer(_FakeFetcher):

self._base_pattern = re.compile(r'.*chrome/common/extensions/(.*)')

def fetch(self, url):

+ url = url.rsplit('?', 1)[0]

path = os.path.join(os.pardir, self._base_pattern.match(url).group(1))

if self._IsDir(path):

html = ['<html>Revision 000000']

@@ -70,6 +71,7 @@ class FakeViewvcServer(_FakeFetcher):

self._base_pattern = re.compile(r'.*chrome/common/extensions/(.*)')

def fetch(self, url):

+ url = url.rsplit('?', 1)[0]

path = os.path.join(os.pardir, self._base_pattern.match(url).group(1))

if self._IsDir(path):

html = ['<table><tbody><tr>...</tr>']