Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: media/base/android/media_player_bridge.h

Issue 14247018: Implement WebRTC in Chrome for TV (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed some comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_player_bridge.h
diff --git a/media/base/android/media_player_bridge.h b/media/base/android/media_player_bridge.h
index c6db77bcda7faf27a4d4a154ca2557800086f79d..190edb0b1a29c466235e0109adf52c3a37e4782c 100644
--- a/media/base/android/media_player_bridge.h
+++ b/media/base/android/media_player_bridge.h
@@ -44,6 +44,16 @@ class MEDIA_EXPORT MediaPlayerBridge {
MEDIA_ERROR_INVALID_CODE,
};
+ // Types of media that this object will play.
Ami GONE FROM CHROMIUM 2013/05/01 22:01:37 Wow, I *seriously* did not understand what you wer
wonsik 2013/05/02 15:22:00 My bad -- I confused implementation details with t
+ enum MediaType {
+ // Plain media from URL.
+ MEDIA_TYPE_DEFAULT,
+ // Media from W3C Media Source Extensions
+ MEDIA_TYPE_MEDIA_SOURCE_EXTENSIONS,
+ // Media from W3C Media Streams.
+ MEDIA_TYPE_MEDIA_STREAMS,
+ };
+
// Callback when error happens. Args: player ID, error type.
typedef base::Callback<void(int, int)> MediaErrorCB;
@@ -82,7 +92,7 @@ class MEDIA_EXPORT MediaPlayerBridge {
static MediaPlayerBridge* Create(
int player_id,
const GURL& url,
- bool is_media_source,
+ MediaType media_type,
const GURL& first_party_for_cookies,
MediaResourceGetter* resource_getter,
bool hide_url_log,

Powered by Google App Engine
This is Rietveld 408576698