Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: media/base/android/media_player_android.h

Issue 14247018: Implement WebRTC in Chrome for TV (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dongwon and Yuncheol's comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_player_android.h
diff --git a/media/base/android/media_player_android.h b/media/base/android/media_player_android.h
index 8dfe90cc58d0be691c092a122dbb70bbc68eab95..a9c73718f3697efbf4ad0e3e8359e4fb03f26281 100644
--- a/media/base/android/media_player_android.h
+++ b/media/base/android/media_player_android.h
@@ -36,6 +36,13 @@ class MEDIA_EXPORT MediaPlayerAndroid {
MEDIA_ERROR_INVALID_CODE,
};
+ // Types of media source that this object will play.
+ enum MediaSourceType {
acolwell GONE FROM CHROMIUM 2013/05/14 18:17:47 nit: s/MediaSourceType/SourceType and s/MEDIA_SOUR
wonsik 2013/05/20 14:02:24 Done.
+ MEDIA_SOURCE_URL,
+ MEDIA_SOURCE_MSE, // W3C Media Source Extensions
+ MEDIA_SOURCE_STREAM, // W3C Media Stream, e.g. getUserMedia().
+ };
+
// Callback when error happens. Args: player ID, error type.
typedef base::Callback<void(int, int)> MediaErrorCB;
@@ -78,7 +85,7 @@ class MEDIA_EXPORT MediaPlayerAndroid {
static MediaPlayerAndroid* Create(
int player_id,
const GURL& url,
- bool is_media_source,
+ MediaSourceType media_source_type,
const GURL& first_party_for_cookies,
bool hide_url_log,
MediaPlayerManager* manager,

Powered by Google App Engine
This is Rietveld 408576698