Implement WebRTC in Chrome for TV

content/renderer/media/rtc_video_decoder_bridge_tv.cc

Index: content/renderer/media/rtc_video_decoder_bridge_tv.cc
diff --git a/content/renderer/media/rtc_video_decoder_bridge_tv.cc b/content/renderer/media/rtc_video_decoder_bridge_tv.cc
new file mode 100644
index 0000000000000000000000000000000000000000..999e0bc7adc52a17bf4fcf85a0dbc2f2bdc4fc28
--- /dev/null
+++ b/content/renderer/media/rtc_video_decoder_bridge_tv.cc
@@ -0,0 +1,141 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/rtc_video_decoder_bridge_tv.h"
+
+#include <queue>
+
+#include "base/bind.h"
+#include "base/callback_helpers.h"
+#include "base/location.h"
+#include "base/logging.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/singleton.h"
+#include "base/message_loop_proxy.h"
+#include "base/time.h"
+#include "content/renderer/media/rtc_video_decoder_factory_tv.h"
+#include "media/base/bind_to_loop.h"
+#include "media/base/decoder_buffer.h"
+#include "third_party/libjingle/source/talk/base/ratetracker.h"
+
+namespace content {
+
+RTCVideoDecoderBridgeTv::RTCVideoDecoderBridgeTv(
+    RTCVideoDecoderFactoryTv* factory)
+    : factory_(factory),
+      is_initialized_(false),
+      first_frame_(true),
+      decode_complete_callback_(NULL) {}
+
+RTCVideoDecoderBridgeTv::~RTCVideoDecoderBridgeTv() {}
+
+int32_t RTCVideoDecoderBridgeTv::InitDecode(
+    const webrtc::VideoCodec* codecSettings,

[acolwell GONE FROM CHROMIUM, 2013/05/14 18:17:47]

nit: change to unix_hacker_style here and below.

[wonsik, 2013/05/20 14:02:24]

Done.

+    int32_t numberOfCores) {
+  if (codecSettings->codecType != webrtc::kVideoCodecVP8)
+    return WEBRTC_VIDEO_CODEC_ERROR;
+  // We don't support feedback mode.
+  if (codecSettings->codecSpecific.VP8.feedbackModeOn)
+    return WEBRTC_VIDEO_CODEC_ERROR;
+
+  if (is_initialized_)

[acolwell GONE FROM CHROMIUM, 2013/05/14 18:17:47]

nit: collapse this and the 2 conditions above into a single if.

[wonsik, 2013/05/20 14:02:24]

Done.

+    return WEBRTC_VIDEO_CODEC_ERROR;
+  size_ = gfx::Size(codecSettings->width, codecSettings->height);
+  is_initialized_ = true;
+  first_frame_ = true;
+  factory_->InitializeStream(size_);
+
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoderBridgeTv::Decode(
+    const webrtc::EncodedImage& inputImage,
+    bool missingFrames,
+    const webrtc::RTPFragmentationHeader* /* fragmentation */,

[acolwell GONE FROM CHROMIUM, 2013/05/14 18:17:47]

are these commented out to silence a warning? If not then remove the /* & */
here and below.

[wonsik, 2013/05/20 14:02:24]

Done.

+    const webrtc::CodecSpecificInfo* /* codecSpecificInfo */,
+    int64_t renderTimeMs) {
+  // Unlike the SW decoder in libvpx, hw decoder can not handle broken frames.
+  // Here, we return an error in order to request a key frame.
+  if (missingFrames || !inputImage._completeFrame)
+    return WEBRTC_VIDEO_CODEC_ERROR;
+
+  if (!is_initialized_ || decode_complete_callback_ == NULL)
+    return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
+
+  if (first_frame_) {
+    // If the first frame is not a key frame, return an error to request a key
+    // frame.
+    if (inputImage._frameType != webrtc::kKeyFrame)
+      return WEBRTC_VIDEO_CODEC_ERROR;
+
+    // Google TV expects timestamp from 0, so we store the initial timestamp as
+    // an offset and subtract the value from every timestamps to meet the
+    // expectation.
+    timestamp_offset_millis_ = renderTimeMs;
+  }
+  first_frame_ = false;
+  gfx::Size new_size;
+  if (inputImage._frameType == webrtc::kKeyFrame &&
+      inputImage._encodedWidth != 0 &&
+      inputImage._encodedHeight != 0) {
+    // Only a key frame has a meaningful size.
+    new_size.SetSize(inputImage._encodedWidth, inputImage._encodedHeight);
+    if (size_ == new_size)
+      new_size = gfx::Size();
+    else
+      size_ = new_size;
+  }
+  // |inputImage_| may be destroyed after this call, so we make a copy of the
+  // buffer so that we can queue the buffer asynchronously.
+  scoped_refptr<media::DecoderBuffer> buffer =
+      media::DecoderBuffer::CopyFrom(inputImage._buffer, inputImage._length);
+  if (renderTimeMs != -1) {
+    buffer->SetTimestamp(base::TimeDelta::FromMilliseconds(
+        renderTimeMs - timestamp_offset_millis_));
+  }
+
+  factory_->QueueBuffer(
+      buffer,
+      base::Bind(&RTCVideoDecoderBridgeTv::RunDecodeCompleteCallback,
+                 decode_complete_callback_,
+                 inputImage._timeStamp),
+      new_size);
+
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoderBridgeTv::RegisterDecodeCompleteCallback(
+    webrtc::DecodedImageCallback* callback) {
+  decode_complete_callback_ = callback;
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoderBridgeTv::Release() {
+  is_initialized_ = false;
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoderBridgeTv::Reset() {
+  first_frame_ = true;
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+// static
+void RTCVideoDecoderBridgeTv::RunDecodeCompleteCallback(
+    webrtc::DecodedImageCallback* callback,
+    int64_t timestamp) {
+  // We call the decode complete callback function to notify libjingle that
+  // decoding is finished. In addition, this also reports back to libjingle that
+  // the particular video frame with |timestamp| is correctly rendered to
+  // libjingle, so that it can generate proper stats.
+  webrtc::I420VideoFrame dummy_video_frame;
+  // Smallest possible non-zero I420 image is 2x2 square, with stride_y being 2
+  // and stride_u & stride_v being 1. In other words, this dummy frame contains
+  // 2x2 y values and 1x1 u & v values each.
+  dummy_video_frame.CreateEmptyFrame(2, 2, 2, 1, 1);

[acolwell GONE FROM CHROMIUM, 2013/05/14 18:17:47]

doesn't libjingle care about the frame size too? Shouldn't the actual size be
passed to this callback as well?

[wonsik, 2013/05/20 14:02:24]

AFAIK libjingle does not report the size of image back to the stats, at least
for now. Since creating a frame consumes megabytes of memory and there are a few
memcpy's in the pipeline which can be performance burden, I am reluctant to pass
the actual size here.

[palmer, 2013/05/20 15:35:17]

How does not passing the size save much space or time?

[acolwell GONE FROM CHROMIUM, 2013/05/20 21:23:21]

Is there a way we can reuse a frame so we only have one copy or defer allocation
until the buffer pointers are actually needed? I'm very wary about lying to
libjingle here. It seems like a violation of the API contract.

[wonsik, 2013/05/21 10:09:29]

OK - not lying now :)

+  dummy_video_frame.set_timestamp(timestamp);
+  callback->Decoded(dummy_video_frame);
+}
+
+}  // namespace content