Implement WebRTC in Chrome for TV

media/base/android/media_player_bridge.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_ANDROID_MEDIA_PLAYER_BRIDGE_H_
 #define MEDIA_BASE_ANDROID_MEDIA_PLAYER_BRIDGE_H_
 
 #include <jni.h>
 #include <map>
 #include <string>
@@ skipping 26 matching lines @@
 class MEDIA_EXPORT MediaPlayerBridge {
  public:
   // Error types for MediaErrorCB.
   enum MediaErrorType {
     MEDIA_ERROR_FORMAT,
     MEDIA_ERROR_DECODE,
     MEDIA_ERROR_NOT_VALID_FOR_PROGRESSIVE_PLAYBACK,
     MEDIA_ERROR_INVALID_CODE,
   };
 
+  // Flags for creation
+  enum Flags {
+    FLAG_MEDIA_SOURCE = 1 << 0,

[qinmin, 2013/04/29 17:31:49]

add a default flag here for non media source case.

[wonsik, 2013/05/01 14:15:38]

Done.

+    FLAG_LOW_LATENCY = 1 << 1,

[Ami GONE FROM CHROMIUM, 2013/04/29 22:11:09]

Neither of these names is meaningful to me.
Does MEDIA_SOURCE refer to the W3C MediaSource Extensions spec, or to the
GoogleTV MediaSource API?
What does LOW_LATENCY refer to?  (why would anyone want _high_ latency? ;))
Needs fuller commentary (since these aren't described in the android doco linked
from the class comment) and hopefully a more specific name for MEDIA_SOURCE (off
the top of my head FLAG_MEDIA_SOURCE_EXTENSIONS and
FLAG_GOOGLETV_MEDIA_SOURCE_API make more sense to me, but that's not to say
there aren't better choices)

[wonsik, 2013/05/01 14:15:38]

Improved names.

+  };
+
   // Callback when error happens. Args: player ID, error type.
   typedef base::Callback<void(int, int)> MediaErrorCB;
 
   // Callback when video size has changed. Args: player ID, width, height.
   typedef base::Callback<void(int, int, int)> VideoSizeChangedCB;
 
   // Callback when buffering has changed. Args: player ID, percentage
   // of the media.
   typedef base::Callback<void(int, int)> BufferingUpdateCB;
 
@@ skipping 18 matching lines @@
   // Callback when DemuxerStreamPlayer wants to read data from the demuxer.
   typedef base::Callback<void(int, DemuxerStream::Type, bool)>
       ReadFromDemuxerCB;
 #endif
 
   static bool RegisterMediaPlayerBridge(JNIEnv* env);
 
   static MediaPlayerBridge* Create(
       int player_id,
       const GURL& url,
-      bool is_media_source,
+      int flags,
       const GURL& first_party_for_cookies,
       MediaResourceGetter* resource_getter,
       bool hide_url_log,
       MediaPlayerBridgeManager* manager,
 #if defined(GOOGLE_TV)
       const ReadFromDemuxerCB read_from_demuxer_cb,
 #endif
       const MediaErrorCB& media_error_cb,
       const VideoSizeChangedCB& video_size_changed_cb,
       const BufferingUpdateCB& buffering_update_cb,
@@ skipping 183 matching lines @@
 
   // Listener object that listens to all the media player events.
   MediaPlayerListener listener_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaPlayerBridge);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_ANDROID_MEDIA_PLAYER_BRIDGE_H_