Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 14247011: drive: Change EventLogger to take printf format (Closed)

Created:
7 years, 8 months ago by satorux1
Modified:
7 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Change EventLogger to take printf format To make it more convenient to use. We might want to use stream instead in the future, but printf format is a good first step. BUG=233448 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M chrome/browser/chromeos/drive/drive_prefetcher.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/event_logger.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/event_logger.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/event_logger_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
7 years, 8 months ago (2013-04-19 02:20:27 UTC) #1
kinaba
cool. lgtm
7 years, 8 months ago (2013-04-19 02:22:03 UTC) #2
satorux1
7 years, 8 months ago (2013-04-19 03:50:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r195081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698