Use --internal-diff only for svn >= 1.7.

Use --internal-diff only for svn >= 1.7.

This removes DiffItem entirely as it was no longer used.

[M-A Ruel, 2013-04-19 16:17:08]

lgtm the rietveld issue is really screwed up.

https://codereview.chromium.org/14247007/diff/1/scm.py
File scm.py (right):

https://codereview.chromium.org/14247007/diff/1/scm.py#newcode786
scm.py:786: # since we want the unified diff.  On svn >= 1.7, the
"--internal-diff" flag
Could you split the comments, move the svn >= 1.7 part inside the condition and
the svn < 1.7 into the else. I think it'd be more readable.

https://codereview.chromium.org/14247007/diff/1/scm.py#newcode815
scm.py:815: data = dict([(f, SVN.CaptureLocalInfo([f], root)) for f in
filenames])
data = dict((f, SVN.CaptureLocalInfo([f], root)) for f in filenames)

[] are unnecessary.

https://codereview.chromium.org/14247007/diff/1/scm.py#newcode860
scm.py:860: for filename in sorted(data.iterkeys()):
for filename in sorted(data):

[Peter Kasting, 2013-04-19 16:29:59]

I'm still worried about how having these changes locally seemed to make me
unable to upload (or at least unable to do so correctly).  You couldn't
reproduce this?

I feel frightened of checking this in without understanding that issue.

[Peter Kasting, 2013-04-19 19:57:52]

I'm going to break this change into pieces, so closing.

First piece is at https://codereview.chromium.org/14241038/ .