Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/chromium.py

Issue 1424693002: Add swarming support for IsolatedScriptTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Add idempotent TODO Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/swarming/api.py ('K') | « scripts/slave/recipe_modules/test_utils/test_api.py ('k') | scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium.py
diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py
index daf9d13111348cdb2c3b24575870f8d77fda3f28..8d74e86d8cf3b319f8ac3586aae684cd3a1fcb1e 100644
--- a/scripts/slave/recipes/chromium.py
+++ b/scripts/slave/recipes/chromium.py
@@ -161,7 +161,6 @@ def GenTests(api):
],
} for b in builders_with_tests
}))
-
yield test
yield (
@@ -234,6 +233,157 @@ def GenTests(api):
)
yield (
Paweł Hajdan Jr. 2015/10/26 17:00:41 Are all of these tests _strictly_ needed (i.e. we
nednguyen 2015/10/27 00:54:29 I got one test removed. The rest are needed for 10
+ api.test('build_dynamic_swarmed_isolated_script_test') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Builder') +
+ api.platform('linux', 64) +
+ api.override_step_data('read test spec', api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ }))
+ )
+
+ yield (
+ api.test('dynamic_swarmed_passed_isolated_script_test') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data('read test spec', api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ }))
+ )
+
+ yield (
+ api.test('dynamic_swarmed_failed_isolated_script_test') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data('read test spec', api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ })) +
+ api.override_step_data('telemetry_gpu_unittests',
+ api.test_utils.canned_isolated_script_output(
+ passing=True, is_win=False, swarming=True,
+ isolated_script_passing=False, valid=True),
+ retcode=255)
+ )
+
+ yield (
+ api.test('dynamic_swarmed_passed_with_bad_retcode_isolated_script_test') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data('read test spec', api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ })) +
+ api.override_step_data('telemetry_gpu_unittests',
+ api.test_utils.canned_isolated_script_output(
+ passing=True, is_win=False, swarming=True,
+ isolated_script_passing=True, valid=True),
+ retcode=255)
+ )
+
+ yield (
+ api.test(
+ 'dynamic_swarmed_passed_isolated_script_test_with_swarming_failure') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data('read test spec', api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ })) +
+ api.override_step_data('telemetry_gpu_unittests',
+ api.test_utils.canned_isolated_script_output(
+ passing=False, is_win=False, swarming=True,
+ swarming_internal_failure=True, isolated_script_passing=True,
+ valid=True),
+ retcode=255)
+ )
+
+ yield (
+ api.test(
+ 'dynamic_swarmed_passed_isolated_script_test_with_no_swarming') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data('read test spec', api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ })) +
+ api.override_step_data('telemetry_gpu_unittests',
+ api.test_utils.canned_isolated_script_output(
+ passing=True, is_win=False, swarming=False,
+ isolated_script_passing=True, valid=True),
+ retcode=255)
+ )
+
+ yield (
api.test('goma_with_diagnose_goma_failure') +
api.properties.generic(mastername='chromium.fyi',
buildername='CrWinGoma') +
« scripts/slave/recipe_modules/swarming/api.py ('K') | « scripts/slave/recipe_modules/test_utils/test_api.py ('k') | scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698