Issue 14246031: Simplified LCodeGen::GetNextEmittedBlock and LCodeGen::EmitGoto a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14246031: Simplified LCodeGen::GetNextEmittedBlock and LCodeGen::EmitGoto a bit. (Closed)

Created:
7 years, 8 months ago by Sven Panne

Modified:
7 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Simplified LCodeGen::GetNextEmittedBlock and LCodeGen::EmitGoto a bit. GetNextEmittedBlock is always called with the same argument (an instance variable), so let's remove it. In EmitGoto, avoid assignment to an argument. This CL is split off another CL for easier reviewing. Committed: http://code.google.com/p/v8/source/detail?r=14349

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -41 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 8 months ago (2013-04-19 12:02:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r14349 (presubmit successful).

Expand Messages | Collapse Messages