Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 14246029: Remove heap snapshot size limit. (Closed)

Created:
7 years, 8 months ago by alph
Modified:
7 years, 8 months ago
Reviewers:
Toon Verwaest, yurys, loislo
CC:
v8-dev
Visibility:
Public.

Description

Remove heap snapshot size limit. As long as frontend now stores snapshots in external arrays it doesn't make sense to check the collected snapshot size on the backend side. In other words if backend has managed to fit the collected snapshot into its memory, it should also fit into the frontend's memory. R=yurys@chromium.org BUG=chromium:232305 Committed: https://code.google.com/p/v8/source/detail?r=14356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M src/heap-snapshot-generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 3 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alph
Folks, please take a look.
7 years, 8 months ago (2013-04-19 09:59:53 UTC) #1
loislo
lgtm
7 years, 8 months ago (2013-04-19 11:26:24 UTC) #2
yurys
lgtm
7 years, 8 months ago (2013-04-19 11:27:10 UTC) #3
alph
Toon, could you please take a look.
7 years, 8 months ago (2013-04-19 12:44:29 UTC) #4
Toon Verwaest
lgtm (rubberstamp)
7 years, 8 months ago (2013-04-19 15:41:14 UTC) #5
alph
7 years, 8 months ago (2013-04-19 15:43:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r14356 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698