Source/core/xml/XMLHttpRequest.idl - Issue 14246006: Implementing timeout support for XHR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XMLHttpRequest.idl

Issue 14246006: Implementing timeout support for XHR (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@timeoutResourceHandle

Patch Set: Adressing eview comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XMLHttpRequest.idl

diff --git a/Source/core/xml/XMLHttpRequest.idl b/Source/core/xml/XMLHttpRequest.idl

index 35b24bea140e30d8cd7df07d861c04819aaa6cbb..440867ece75966669ae28a371ed3dc0b8bbfe92e 100644

--- a/Source/core/xml/XMLHttpRequest.idl

+++ b/Source/core/xml/XMLHttpRequest.idl

@@ -51,7 +51,7 @@ enum XMLHttpRequestResponseType {

attribute EventListener onloadend;

attribute EventListener onloadstart;

attribute EventListener onprogress;

- [Conditional=XHR_TIMEOUT] attribute EventListener ontimeout;

+ attribute EventListener ontimeout;

// event handler attributes

attribute EventListener onreadystatechange;

@@ -63,7 +63,7 @@ enum XMLHttpRequestResponseType {

const unsigned short LOADING = 3;

const unsigned short DONE = 4;

- [Conditional=XHR_TIMEOUT, SetterRaisesException] attribute unsigned long timeout;

+ [SetterRaisesException] attribute unsigned long timeout;

readonly attribute unsigned short readyState;

[SetterRaisesException] attribute boolean withCredentials;

« Source/core/platform/network/chromium/ResourceHandleInternal.h ('K') | « Source/core/xml/XMLHttpRequest.cpp ('k') | Source/wtf/FeatureDefines.h » ('j') | no next file with comments »