Update layout tests to use internals.visualViewport APIs.

Update layout tests to use inernals.visualViewport APIs.

This CL adds the following methods to Internals.cpp for tests that need the
visual viewport scroll position and dimensions: visualViewportHeight,
visualViewportWidth, visualViewportScrollX, visualViewportScrollY.

This is the initial CL to fix the LayoutTests that would break if the
corresponding window properties were relative to the visual viewport. This CL
branched from another CL to make shipping this window API change easier.

Original review CL: https://codereview.chromium.org/1415513002

TBR=rbyers@chromium.org

BUG=489206
Committed: https://crrev.com/8e61efca851565188257eb9f547d601f8d90e938
Cr-Commit-Position: refs/heads/master@{#355926}

[ymalik, 2015-10-23 18:47:25]

Description was changed from

==========
Update layout tests to use inernals.visualViewport APIs.

This CL adds the following methods to Internals.cpp for tests that need the
visual viewport scroll position and dimensions: visualViewportHeight,
visualViewportWidth, visualViewportScrollX, visualViewportScrollY.

This is the initial CL to fix the LayoutTests that would break if the
corresponding window properties were relative to the visual viewport. This CL
branched from another CL to make shipping this window API change easier.

Original review CL: https://codereview.chromium.org/1415513002

BUG=489206
==========

to

==========
Update layout tests to use inernals.visualViewport APIs.

This CL adds the following methods to Internals.cpp for tests that need the
visual viewport scroll position and dimensions: visualViewportHeight,
visualViewportWidth, visualViewportScrollX, visualViewportScrollY.

This is the initial CL to fix the LayoutTests that would break if the
corresponding window properties were relative to the visual viewport. This CL
branched from another CL to make shipping this window API change easier.

Original review CL: https://codereview.chromium.org/1415513002

BUG=489206
==========

[ymalik, 2015-10-23 18:48:51]

ymalik@chromium.org changed reviewers:
+ bokan@chromium.org

[ymalik, 2015-10-23 18:49:54]

Hey David, just need your stamp here. You already reviewed these changes in the
original CL.

[ymalik, 2015-10-23 18:52:31]

ymalik@chromium.org changed reviewers:
+ rbyers@chromium.org

[ymalik, 2015-10-23 18:52:31]

+Rick

I decided to break my original CL to make shipping it easier. These changes are
sort of isolated from launching the inert-visual-viewport flag by default. Just
need your stamp again :)

[bokan, 2015-10-23 19:25:27]

lgtm

I think if these changes have already been stamped, it's ok to use TBR= (and and
to Reviewers list).

[ymalik, 2015-10-23 20:27:11]

Description was changed from

==========
Update layout tests to use inernals.visualViewport APIs.

This CL adds the following methods to Internals.cpp for tests that need the
visual viewport scroll position and dimensions: visualViewportHeight,
visualViewportWidth, visualViewportScrollX, visualViewportScrollY.

This is the initial CL to fix the LayoutTests that would break if the
corresponding window properties were relative to the visual viewport. This CL
branched from another CL to make shipping this window API change easier.

Original review CL: https://codereview.chromium.org/1415513002

BUG=489206
==========

to

==========
Update layout tests to use inernals.visualViewport APIs.

This CL adds the following methods to Internals.cpp for tests that need the
visual viewport scroll position and dimensions: visualViewportHeight,
visualViewportWidth, visualViewportScrollX, visualViewportScrollY.

This is the initial CL to fix the LayoutTests that would break if the
corresponding window properties were relative to the visual viewport. This CL
branched from another CL to make shipping this window API change easier.

Original review CL: https://codereview.chromium.org/1415513002

TBR=rbyers@chromium.org

BUG=489206
==========

[ymalik, 2015-10-23 20:28:16]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2015-10-23 20:28:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424593002/20001

[commit-bot: I haz the power, 2015-10-23 23:44:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-23 23:45:27]

Patchset 2 (id:??) landed as
https://crrev.com/8e61efca851565188257eb9f547d601f8d90e938
Cr-Commit-Position: refs/heads/master@{#355926}

[Rick Byers, 2015-10-26 14:04:10]

LGTM.

And yes, TBR was fine IMHO given there was no real change to this code after I
reviewed it.