Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1424523002: [turbofan] Fix and enable property stores. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix and enable property stores. Fix lookup for storing to properties, and also make sure we don't embed deprecated map (using Map::TryUpdate). R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/70158828b3db8e582344272c6c11a957f4d8b2c8 Cr-Commit-Position: refs/heads/master@{#31509}

Patch Set 1 #

Patch Set 2 : Fix invalid type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 6 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-23 09:05:08 UTC) #1
Jarin
lgtm
5 years, 2 months ago (2015-10-23 10:18:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424523002/20001
5 years, 2 months ago (2015-10-23 10:28:38 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-23 10:29:57 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/70158828b3db8e582344272c6c11a957f4d8b2c8 Cr-Commit-Position: refs/heads/master@{#31509}
5 years, 2 months ago (2015-10-23 10:30:25 UTC) #6
Michael Achenbach
5 years, 2 months ago (2015-10-23 11:15:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1414743005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks benchmarks:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%2....

Powered by Google App Engine
This is Rietveld 408576698