Page Serializer: Specify encoding for serialized CSS files

third_party/WebKit/Source/web/tests/PageSerializerTest.cpp

 /*
  * Copyright (c) 2013, Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 321 matching lines @@
     EXPECT_TRUE(isSerialized("orange_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("yellow_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("green_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("blue_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("purple_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("pink_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("brown_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("ul-dot.png", "image/png"));
     EXPECT_TRUE(isSerialized("ol-dot.png", "image/png"));
 
+    // Ensure encodings are specified.
+    EXPECT_TRUE(getSerializedData("link_styles.css", "text/css").startsWith("@charset \"windows-1252\";"));

[yosin_UTC9, 2015/10/28 00:14:57]

Does this work systems uses non-US locale? I'm not sure, whether test_runner
uses "windows-1252" as
default charset or not.

[jsbell, 2015/10/28 18:16:55]

Pretty sure it does; most of the Web is defined as windows-1252 by default,
regardless of system settings, but users can override.

jshin@ - do you happen to know?

Seemed to pass on the bots. I could reduce this down to asserting
startsWith("@charset") - thoughts?

[yosin_UTC9, 2015/10/30 01:57:01]

Since value of @charset for no @charset case isn't matter, I think
startsWith("@charset") is enough.

+    EXPECT_TRUE(getSerializedData("import_styles.css", "text/css").startsWith("@charset \"windows-1252\";"));
+    EXPECT_TRUE(getSerializedData("import_style_from_link.css", "text/css").startsWith("@charset \"windows-1252\";"));
+    EXPECT_TRUE(getSerializedData("encoding.css", "text/css").startsWith("@charset \"euc-kr\";"));
+
     // Ensure that stylesheet contents are not NFC-normalized before encoding.
     EXPECT_TRUE(getSerializedData("encoding.css", "text/css").contains("\xE4\xC5\xD1\xE2"));
     EXPECT_FALSE(getSerializedData("encoding.css", "text/css").contains("\xE4\xC5\xE4\xC5"));
 }
 
 TEST_F(PageSerializerTest, CSSImport)
 {
     setBaseFolder("pageserializer/css/");
 
     registerURL("import.html", "text/html");
@@ skipping 155 matching lines @@
     EXPECT_EQ("saved from url=(0015)http://foo.com/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com")));
     EXPECT_EQ("saved from url=(0015)http://f-o.com/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://f-o.com")));
     EXPECT_EQ("saved from url=(0019)http://foo.com-%2D/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com--")));
     EXPECT_EQ("saved from url=(0024)http://f-%2D.com-%2D%3E/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://f--.com-->")));
     EXPECT_EQ("saved from url=(0020)http://foo.com/?-%2D", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com?--")));
     EXPECT_EQ("saved from url=(0020)http://foo.com/#-%2D", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#--")));
     EXPECT_EQ("saved from url=(0026)http://foo.com/#bar-%2Dbaz", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#bar--baz")));
 }
 
 } // namespace blink