Page Serializer: Specify encoding for serialized CSS files

third_party/WebKit/Source/core/page/PageSerializer.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 379 matching lines @@
         // TODO(lukasza): This causes incomplete MHTML for OOPIFs.
         // (crbug.com/538766)
         if (childFrame->isLocalFrame())
             serializeFrame(toLocalFrame(childFrame));
     }
 }
 
 void PageSerializer::serializeCSSStyleSheet(CSSStyleSheet& styleSheet, const KURL& url)
 {
     StringBuilder cssText;
+    cssText.appendLiteral("@charset \"");

[jsbell, 2015/10/27 17:52:43]

We could skip this if the encoding is the default (windows-1252).

[yosin_UTC9, 2015/10/28 00:14:57]

Really? I think default charset depends of Chrome's language
settings or charset from HTML document. Not sure.

[jsbell, 2015/10/28 18:16:55]

Oh, good point. Always outputting seems sensible then, especially as the context
could change for serialized files.

[jsbell, 2015/11/02 23:55:38]

Done.

+    cssText.append(styleSheet.contents()->charset().lower());
+    cssText.appendLiteral("\";\n\n");
+
     for (unsigned i = 0; i < styleSheet.length(); ++i) {
         CSSRule* rule = styleSheet.item(i);
         String itemText = rule->cssText();
         if (!itemText.isEmpty()) {
             cssText.append(itemText);
             if (i < styleSheet.length() - 1)
                 cssText.appendLiteral("\n\n");
         }
 
         // Some rules have resources associated with them that we need to retrieve.
         serializeCSSRule(rule);
     }
 
     if (url.isValid() && !m_resourceURLs.contains(url)) {
         // FIXME: We should check whether a charset has been specified and if none was found add one.

[jsbell, 2015/10/27 17:52:43]

Not sure if the FIXME here is referring to the lack of a charset in the
styleSheet itself (it has one implicitly, so far as I can tell) or @charset (in
which case, addressed by this CL)

Remove?

[yosin_UTC9, 2015/10/30 01:57:01]

Agree. This patch always adds @charset.

[jsbell, 2015/11/02 23:55:38]

Done.

         WTF::TextEncoding textEncoding(styleSheet.contents()->charset());
         ASSERT(textEncoding.isValid());
-        // TODO(jsbell): Ensure @charset is written out if non-UTF-8.
         String textString = cssText.toString();
         CString text = textEncoding.encode(textString, WTF::EntitiesForUnencodables);
         m_resources->append(SerializedResource(url, String("text/css"), SharedBuffer::create(text.data(), text.length())));
         m_resourceURLs.add(url);
     }
 }
 
 void PageSerializer::serializeCSSRule(CSSRule* rule)
 {
     ASSERT(rule->parentStyleSheet()->ownerDocument());
@@ skipping 167 matching lines @@
             continue;
         }
         emitsMinus = ch == '-';
         builder.append(ch);
     }
     CString escapedUrl = builder.toString().ascii();
     return String::format("saved from url=(%04d)%s", static_cast<int>(escapedUrl.length()), escapedUrl.data());
 }
 
 } // namespace blink