Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1424503003: Reland^2 "Use C++ implementation of Object.definePropert{y,ies}" (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland^2 "Use C++ implementation of Object.definePropert{y,ies}" along with follow-up fixes: - "introduce LookupIterator::Restart() and use it" - "always reset the LookupIterator before storing" - "API-style accessors can throw, check for that" Revert reason was fixed in Chromium: https://codereview.chromium.org/1415453003/ This reverts the following commits: 0188aeadbbb9678eb11223a53d0bbb12d2f07ab9 984f8af8922d368755d9dd6e2537817d66ae4530 dc9d2c16cd486b38948102df840829674f1e799a a0f5d4995c9edc99b97d6b3bc3e4081891eb7f91 Committed: https://crrev.com/5edebf66282b26f866e018ac1cf00ba245426173 Cr-Commit-Position: refs/heads/master@{#31578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -89 lines) Patch
M src/js/v8natives.js View 2 chunks +54 lines, -44 lines 0 comments Download
M src/lookup.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 10 chunks +36 lines, -12 lines 0 comments Download
M src/property-descriptor.cc View 3 chunks +9 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jakob Kummerow
You've seen all of this before. Third time's the charm?
5 years, 1 month ago (2015-10-26 15:53:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424503003/1
5 years, 1 month ago (2015-10-26 15:55:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 16:14:20 UTC) #6
Toon Verwaest
rubberstamp lgtm
5 years, 1 month ago (2015-10-26 16:20:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424503003/1
5 years, 1 month ago (2015-10-26 16:37:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 16:39:00 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 16:39:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5edebf66282b26f866e018ac1cf00ba245426173
Cr-Commit-Position: refs/heads/master@{#31578}

Powered by Google App Engine
This is Rietveld 408576698