chromeos/arc/bridge/common/arc_host_messages.h - Issue 1424503002: arc-bridge: Add IPC message definitions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/arc/bridge/common/arc_host_messages.h

Issue 1424503002: arc-bridge: Add IPC message definitions (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Renamed libarcbridge=>bridge/common and addressed feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromeos/arc/bridge/common/arc_bridge.cc ('K') | « chromeos/arc/bridge/common/arc_bridge.cc ('k') | chromeos/arc/bridge/common/arc_instance_messages.h » ('j') | chromeos/arc/bridge/common/arc_instance_messages.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	Shuhei Takahashi 2015/10/26 11:13:40 Why did you decide to have two message definition Why did you decide to have two message definition files? As you see in ipc_message_start.h, it is a rare case. Luis Héctor Chávez 2015/10/26 21:03:27 To make it possible to add messages to the code wi Show quoted text On 2015/10/26 11:13:40, Shuhei Takahashi wrote: > Why did you decide to have two message definition files? As you see in > ipc_message_start.h, it is a rare case. To make it possible to add messages to the code without having the generated message IDs for other messages change (by only appending to these files).
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Messages sent from the host to the ARC instance

	6 // Multiply-included message file, hence no include guard.

	7

	8 #include <stdint.h>

	9

	10 #include "ipc/ipc_message_macros.h"

	11

	12 #define IPC_MESSAGE_START ArcHostMsgStart

	13

	14 IPC_MESSAGE_CONTROL0(ArcHostMsg_Pong)
	Shuhei Takahashi 2015/10/26 11:13:40 Typically this should be named as ArcInstanceHostM Typically this should be named as ArcInstanceHostMsg_. I looked for chromium codebase but could not find an exceptional naming like this. Luis Héctor Chávez* 2015/10/26 21:03:27 Done Show quoted text On 2015/10/26 11:13:40, Shuhei Takahashi wrote: > Typically this should be named as ArcInstanceHostMsg_*. I looked for chromium > codebase but could not find an exceptional naming like this. Done
	15 IPC_MESSAGE_CONTROL0(ArcHostMsg_InstanceReady)

OLD	NEW