Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: components/sessions/core/serialized_navigation_entry_unittest.cc

Issue 1424493002: [Sync] Deprecate sync session page state field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sessions/core/serialized_navigation_entry.h" 5 #include "components/sessions/core/serialized_navigation_entry.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 15 matching lines...) Expand all
26 namespace { 26 namespace {
27 27
28 // Create a sync_pb::TabNavigation from the constants above. 28 // Create a sync_pb::TabNavigation from the constants above.
29 sync_pb::TabNavigation MakeSyncDataForTest() { 29 sync_pb::TabNavigation MakeSyncDataForTest() {
30 sync_pb::TabNavigation sync_data; 30 sync_pb::TabNavigation sync_data;
31 sync_data.set_virtual_url(test_data::kVirtualURL.spec()); 31 sync_data.set_virtual_url(test_data::kVirtualURL.spec());
32 sync_data.set_referrer(test_data::kReferrerURL.spec()); 32 sync_data.set_referrer(test_data::kReferrerURL.spec());
33 sync_data.set_obsolete_referrer_policy(test_data::kReferrerPolicy); 33 sync_data.set_obsolete_referrer_policy(test_data::kReferrerPolicy);
34 sync_data.set_correct_referrer_policy(test_data::kReferrerPolicy); 34 sync_data.set_correct_referrer_policy(test_data::kReferrerPolicy);
35 sync_data.set_title(base::UTF16ToUTF8(test_data::kTitle)); 35 sync_data.set_title(base::UTF16ToUTF8(test_data::kTitle));
36 sync_data.set_state(test_data::kEncodedPageState);
37 sync_data.set_page_transition( 36 sync_data.set_page_transition(
38 sync_pb::SyncEnums_PageTransition_AUTO_SUBFRAME); 37 sync_pb::SyncEnums_PageTransition_AUTO_SUBFRAME);
39 sync_data.set_unique_id(test_data::kUniqueID); 38 sync_data.set_unique_id(test_data::kUniqueID);
40 sync_data.set_timestamp_msec(syncer::TimeToProtoTime(test_data::kTimestamp)); 39 sync_data.set_timestamp_msec(syncer::TimeToProtoTime(test_data::kTimestamp));
41 sync_data.set_redirect_type(sync_pb::SyncEnums::CLIENT_REDIRECT); 40 sync_data.set_redirect_type(sync_pb::SyncEnums::CLIENT_REDIRECT);
42 sync_data.set_navigation_home_page(true); 41 sync_data.set_navigation_home_page(true);
43 sync_data.set_search_terms(base::UTF16ToUTF8(test_data::kSearchTerms)); 42 sync_data.set_search_terms(base::UTF16ToUTF8(test_data::kSearchTerms));
44 sync_data.set_favicon_url(test_data::kFaviconURL.spec()); 43 sync_data.set_favicon_url(test_data::kFaviconURL.spec());
45 sync_data.set_http_status_code(test_data::kHttpStatusCode); 44 sync_data.set_http_status_code(test_data::kHttpStatusCode);
46 // The redirect chain only syncs one way. 45 // The redirect chain only syncs one way.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 79
81 const SerializedNavigationEntry& navigation = 80 const SerializedNavigationEntry& navigation =
82 SerializedNavigationEntry::FromSyncData(test_data::kIndex, sync_data); 81 SerializedNavigationEntry::FromSyncData(test_data::kIndex, sync_data);
83 82
84 EXPECT_EQ(test_data::kIndex, navigation.index()); 83 EXPECT_EQ(test_data::kIndex, navigation.index());
85 EXPECT_EQ(test_data::kUniqueID, navigation.unique_id()); 84 EXPECT_EQ(test_data::kUniqueID, navigation.unique_id());
86 EXPECT_EQ(test_data::kReferrerURL, navigation.referrer_url()); 85 EXPECT_EQ(test_data::kReferrerURL, navigation.referrer_url());
87 EXPECT_EQ(test_data::kReferrerPolicy, navigation.referrer_policy()); 86 EXPECT_EQ(test_data::kReferrerPolicy, navigation.referrer_policy());
88 EXPECT_EQ(test_data::kVirtualURL, navigation.virtual_url()); 87 EXPECT_EQ(test_data::kVirtualURL, navigation.virtual_url());
89 EXPECT_EQ(test_data::kTitle, navigation.title()); 88 EXPECT_EQ(test_data::kTitle, navigation.title());
90 EXPECT_EQ(test_data::kEncodedPageState, navigation.encoded_page_state());
91 EXPECT_EQ(test_data::kTransitionType, navigation.transition_type()); 89 EXPECT_EQ(test_data::kTransitionType, navigation.transition_type());
92 EXPECT_FALSE(navigation.has_post_data()); 90 EXPECT_FALSE(navigation.has_post_data());
93 EXPECT_EQ(-1, navigation.post_id()); 91 EXPECT_EQ(-1, navigation.post_id());
94 EXPECT_EQ(GURL(), navigation.original_request_url()); 92 EXPECT_EQ(GURL(), navigation.original_request_url());
95 EXPECT_FALSE(navigation.is_overriding_user_agent()); 93 EXPECT_FALSE(navigation.is_overriding_user_agent());
96 EXPECT_TRUE(navigation.timestamp().is_null()); 94 EXPECT_TRUE(navigation.timestamp().is_null());
97 EXPECT_EQ(test_data::kSearchTerms, navigation.search_terms()); 95 EXPECT_EQ(test_data::kSearchTerms, navigation.search_terms());
98 EXPECT_EQ(test_data::kFaviconURL, navigation.favicon_url()); 96 EXPECT_EQ(test_data::kFaviconURL, navigation.favicon_url());
99 EXPECT_EQ(test_data::kHttpStatusCode, navigation.http_status_code()); 97 EXPECT_EQ(test_data::kHttpStatusCode, navigation.http_status_code());
100 // The redirect chain only syncs one way. 98 // The redirect chain only syncs one way.
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 // it. The protocol buffer should have matching fields to the 139 // it. The protocol buffer should have matching fields to the
142 // SerializedNavigationEntry (when applicable). 140 // SerializedNavigationEntry (when applicable).
143 TEST(SerializedNavigationEntryTest, ToSyncData) { 141 TEST(SerializedNavigationEntryTest, ToSyncData) {
144 const SerializedNavigationEntry navigation = 142 const SerializedNavigationEntry navigation =
145 SerializedNavigationEntryTestHelper::CreateNavigationForTest(); 143 SerializedNavigationEntryTestHelper::CreateNavigationForTest();
146 const sync_pb::TabNavigation sync_data = navigation.ToSyncData(); 144 const sync_pb::TabNavigation sync_data = navigation.ToSyncData();
147 145
148 EXPECT_EQ(test_data::kVirtualURL.spec(), sync_data.virtual_url()); 146 EXPECT_EQ(test_data::kVirtualURL.spec(), sync_data.virtual_url());
149 EXPECT_EQ(test_data::kReferrerURL.spec(), sync_data.referrer()); 147 EXPECT_EQ(test_data::kReferrerURL.spec(), sync_data.referrer());
150 EXPECT_EQ(test_data::kTitle, base::ASCIIToUTF16(sync_data.title())); 148 EXPECT_EQ(test_data::kTitle, base::ASCIIToUTF16(sync_data.title()));
151 EXPECT_TRUE(sync_data.state().empty());
152 EXPECT_EQ(sync_pb::SyncEnums_PageTransition_AUTO_SUBFRAME, 149 EXPECT_EQ(sync_pb::SyncEnums_PageTransition_AUTO_SUBFRAME,
153 sync_data.page_transition()); 150 sync_data.page_transition());
154 EXPECT_TRUE(sync_data.has_redirect_type()); 151 EXPECT_TRUE(sync_data.has_redirect_type());
155 EXPECT_EQ(test_data::kUniqueID, sync_data.unique_id()); 152 EXPECT_EQ(test_data::kUniqueID, sync_data.unique_id());
156 EXPECT_EQ(syncer::TimeToProtoTime(test_data::kTimestamp), 153 EXPECT_EQ(syncer::TimeToProtoTime(test_data::kTimestamp),
157 sync_data.timestamp_msec()); 154 sync_data.timestamp_msec());
158 EXPECT_EQ(test_data::kTimestamp.ToInternalValue(), sync_data.global_id()); 155 EXPECT_EQ(test_data::kTimestamp.ToInternalValue(), sync_data.global_id());
159 EXPECT_EQ(test_data::kFaviconURL.spec(), sync_data.favicon_url()); 156 EXPECT_EQ(test_data::kFaviconURL.spec(), sync_data.favicon_url());
160 EXPECT_EQ(test_data::kHttpStatusCode, sync_data.http_status_code()); 157 EXPECT_EQ(test_data::kHttpStatusCode, sync_data.http_status_code());
161 // The proto navigation redirects don't include the final chain entry 158 // The proto navigation redirects don't include the final chain entry
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 const ui::PageTransition constructed_transition = 215 const ui::PageTransition constructed_transition =
219 constructed_nav.transition_type(); 216 constructed_nav.transition_type();
220 217
221 EXPECT_EQ(transition, constructed_transition); 218 EXPECT_EQ(transition, constructed_transition);
222 } 219 }
223 } 220 }
224 } 221 }
225 222
226 } // namespace 223 } // namespace
227 } // namespace sessions 224 } // namespace sessions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698