Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1424473002: android gyp/gn: Split out sync compositor source set (Closed)

Created:
5 years, 2 months ago by no sievers
Modified:
5 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android gyp/gn: Split out sync compositor source set Makes it a little easier to untangle dependencies and source sets for the android + aura build. BUG=507792 Committed: https://crrev.com/20f6367b6cd95ead067a0716709bdb2afa776be9 Cr-Commit-Position: refs/heads/master@{#355678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M content/browser/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
no sievers
ptal
5 years, 2 months ago (2015-10-22 22:22:04 UTC) #3
boliu
lgtm Hmm, aura will have sync compositing code right? But only for android I guess.
5 years, 2 months ago (2015-10-22 22:27:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424473002/1
5 years, 2 months ago (2015-10-22 22:47:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 23:54:50 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 23:55:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20f6367b6cd95ead067a0716709bdb2afa776be9
Cr-Commit-Position: refs/heads/master@{#355678}

Powered by Google App Engine
This is Rietveld 408576698