Issue 1424463002: roll mini_chromium to 8d42e2439aa0bd677dca64ba3070f3fa2353b7f2

Issue 1424463002: roll mini_chromium to 8d42e2439aa0bd677dca64ba3070f3fa2353b7f2 (Closed)

Created:
5 years, 2 months ago by scottmg

Modified:
5 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

roll mini_chromium to 8d42e2439aa0bd677dca64ba3070f3fa2353b7f2 8d42e24 win: Enable C4800, implicit bool conversion 82060c1 mac: Make Mach port scopers better ScopedGenerics d7270da Fix base::RandDouble() R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/26b69135120f8209713fbb58febead9e687a5ee4 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/63916623cd6392930b630959fa2c78cee0667fb0

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (2 generated)

Mark Mentovai

LGTM. This supersedes https://codereview.chromium.org/1424453002/.

5 years, 2 months ago (2015-10-22 21:48:58 UTC) #2

scottmg

Committed patchset #1 (id:1) manually as 26b69135120f8209713fbb58febead9e687a5ee4 (presubmit successful).

5 years, 2 months ago (2015-10-22 21:49:56 UTC) #3

scottmg

I landed the wrong hash. I think I copied from the local commit rather than ...

5 years, 2 months ago (2015-10-22 22:01:17 UTC) #6

scottmg

Committed patchset #2 (id:20001) manually as 63916623cd6392930b630959fa2c78cee0667fb0 (presubmit successful).

5 years, 2 months ago (2015-10-22 22:02:54 UTC) #7

Mark Mentovai

5 years, 2 months ago (2015-10-22 23:18:28 UTC) #8

Message was sent while issue was closed.

And it was the one time I didn’t double-check, of course. Thanks for the fix,
LGTM, obviously.