Make compat export include_dirs to all dependents

Make compat export include_dirs to all dependents

At the moment, when I try to build a .cc that includes
third_party/crashpad/crashpad/client/<something>.h in Chromium, I get
compile errors about ssize_t in util/file/file_io.h.

One possible solution is to push the include dir exports out to
everything (which is what's in this CL). I think this will probably
work, but I'm not sure if it's a great idea. I'm a little nervous about
using the fake #include_next more broadly (i.e. exposing it to
Chromium), so maybe we should instead say that client cannot use compat.

I added the dependency here: https://codereview.chromium.org/875043004/
which was maybe a mistake. In practice it only seems to be for ssize_t
usage in util headers, so file_io.h could just have it's own typedef
for that.

R=mark@chromium.org
BUG=chromium:546288, crashpad:1

[scottmg, 2015-10-22 19:48:47]

Description was changed from

==========
Make compat export include_dirs to all dependents

At the moment, when I try to build a .cc that include
third_party/crashpad/crashpad/client/<something>.h in Chromium, I get
compile errors about ssize_t in util/file/file_io.h.

One possible solution is to push the include dir exports out to
everything (which is what's in this CL). I think this will probably
work, but I'm not sure if it's a great idea. I'm a little nervous about
using the fake #include_next more broadly (i.e. exposing it to
Chromium), so maybe we should instead say that client cannot use compat
instead.

I added the dependency here: https://codereview.chromium.org/875043004/
which was maybe a mistake. In practice it only seems to be for ssize_t
usage in util headers.

R=mark@chromium.org
BUG=chromium:546288,crashpad:1
==========

to

==========
Make compat export include_dirs to all dependents

At the moment, when I try to build a .cc that includes
third_party/crashpad/crashpad/client/<something>.h in Chromium, I get
compile errors about ssize_t in util/file/file_io.h.

One possible solution is to push the include dir exports out to
everything (which is what's in this CL). I think this will probably
work, but I'm not sure if it's a great idea. I'm a little nervous about
using the fake #include_next more broadly (i.e. exposing it to
Chromium), so maybe we should instead say that client cannot use compat
instead.

I added the dependency here: https://codereview.chromium.org/875043004/
which was maybe a mistake. In practice it only seems to be for ssize_t
usage in util headers.

R=mark@chromium.org
BUG=chromium:546288,crashpad:1
==========

[scottmg, 2015-10-22 19:49:47]

Description was changed from

==========
Make compat export include_dirs to all dependents

At the moment, when I try to build a .cc that includes
third_party/crashpad/crashpad/client/<something>.h in Chromium, I get
compile errors about ssize_t in util/file/file_io.h.

One possible solution is to push the include dir exports out to
everything (which is what's in this CL). I think this will probably
work, but I'm not sure if it's a great idea. I'm a little nervous about
using the fake #include_next more broadly (i.e. exposing it to
Chromium), so maybe we should instead say that client cannot use compat
instead.

I added the dependency here: https://codereview.chromium.org/875043004/
which was maybe a mistake. In practice it only seems to be for ssize_t
usage in util headers.

R=mark@chromium.org
BUG=chromium:546288,crashpad:1
==========

to

==========
Make compat export include_dirs to all dependents

At the moment, when I try to build a .cc that includes
third_party/crashpad/crashpad/client/<something>.h in Chromium, I get
compile errors about ssize_t in util/file/file_io.h.

One possible solution is to push the include dir exports out to
everything (which is what's in this CL). I think this will probably
work, but I'm not sure if it's a great idea. I'm a little nervous about
using the fake #include_next more broadly (i.e. exposing it to
Chromium), so maybe we should instead say that client cannot use compat
instead.

I added the dependency here: https://codereview.chromium.org/875043004/
which was maybe a mistake. In practice it only seems to be for ssize_t
usage in util headers, so file_io.h could just have it's own typedef
for that.

R=mark@chromium.org
BUG=chromium:546288,crashpad:1
==========

[scottmg, 2015-10-22 19:51:00]

Description was changed from

==========
Make compat export include_dirs to all dependents

At the moment, when I try to build a .cc that includes
third_party/crashpad/crashpad/client/<something>.h in Chromium, I get
compile errors about ssize_t in util/file/file_io.h.

One possible solution is to push the include dir exports out to
everything (which is what's in this CL). I think this will probably
work, but I'm not sure if it's a great idea. I'm a little nervous about
using the fake #include_next more broadly (i.e. exposing it to
Chromium), so maybe we should instead say that client cannot use compat
instead.

I added the dependency here: https://codereview.chromium.org/875043004/
which was maybe a mistake. In practice it only seems to be for ssize_t
usage in util headers, so file_io.h could just have it's own typedef
for that.

R=mark@chromium.org
BUG=chromium:546288,crashpad:1
==========

to

==========
Make compat export include_dirs to all dependents

At the moment, when I try to build a .cc that includes
third_party/crashpad/crashpad/client/<something>.h in Chromium, I get
compile errors about ssize_t in util/file/file_io.h.

One possible solution is to push the include dir exports out to
everything (which is what's in this CL). I think this will probably
work, but I'm not sure if it's a great idea. I'm a little nervous about
using the fake #include_next more broadly (i.e. exposing it to
Chromium), so maybe we should instead say that client cannot use compat.

I added the dependency here: https://codereview.chromium.org/875043004/
which was maybe a mistake. In practice it only seems to be for ssize_t
usage in util headers, so file_io.h could just have it's own typedef
for that.

R=mark@chromium.org
BUG=chromium:546288,crashpad:1
==========

[Mark Mentovai, 2015-10-22 20:27:32]

I think that this leaks too much.

I’ve rarely seen any good use of all_dependent_settings.

[scottmg, 2015-10-22 20:55:16]

On 2015/10/22 20:27:32, Mark Mentovai wrote:
> I think that this leaks too much.
> 
> I’ve rarely seen any good use of all_dependent_settings.

Agreed, closing.