Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1424433002: Updated trace test expectation name. (Closed)

Created:
5 years, 2 months ago by David Yen
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated trace test expectation name. The trace test name was recently changed from TraceTest to trace_test, this made the skip logic no longer work. I have updated the trace test name and also marked these tests as Flaky instead of just Skipped. R=kbr@chromium.org BUG=546519 TEST=run trace_test locally and verify tests are skipped Committed: https://crrev.com/64d17edfdb8dfc3795fac908c0781c7f5937312a Cr-Commit-Position: refs/heads/master@{#355656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/test/gpu/gpu_tests/trace_test_expectations.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
David Yen
5 years, 2 months ago (2015-10-22 19:08:28 UTC) #1
Ken Russell (switch to Gerrit)
I think this should be done first anyway -- lgtm
5 years, 2 months ago (2015-10-22 21:28:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424433002/1
5 years, 2 months ago (2015-10-22 22:17:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 22:23:06 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 22:23:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64d17edfdb8dfc3795fac908c0781c7f5937312a
Cr-Commit-Position: refs/heads/master@{#355656}

Powered by Google App Engine
This is Rietveld 408576698