Issue 14244023: Inline isUint32() method from HConstant, which was only used in one place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14244023: Inline isUint32() method from HConstant, which was only used in one place. (Closed)

Created:
7 years, 8 months ago by titzer

Modified:
7 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline isUint32() method from HConstant, which was only used in one place. Add utility method for checking whether an HValue is a given int32_t constant. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14329

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use IsInteger32Constant() and GetInteger32Constant() #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -17 lines)			Patch
M	src/hydrogen.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

https://codereview.chromium.org/14244023/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14244023/diff/1/src/hydrogen-instructions.cc#newcode654 src/hydrogen-instructions.cc:654: && HConstant::cast(this)->Integer32Value() == value; Use a combination of IsInteger32Constant ...

7 years, 8 months ago (2013-04-18 09:46:22 UTC) #2

titzer

7 years, 8 months ago (2013-04-18 11:22:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14329 (presubmit successful).

Expand Messages | Collapse Messages