Source/bindings/tests/results/V8TestEventConstructor.cpp - Issue 14244017: Make length property return useful values for DOM bindings functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestEventConstructor.cpp

Issue 14244017: Make length property return useful values for DOM bindings functions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace [Optional] by optional Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestCustomNamedGetter.cpp ('k') | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestEventConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestEventConstructor.cpp b/Source/bindings/tests/results/V8TestEventConstructor.cpp

index 006d990678e6cf69a2b2b12dd352c96dd4b0f937..2409bebb73f6b04001ef7cce23dd313f0f14e2be 100644

--- a/Source/bindings/tests/results/V8TestEventConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestEventConstructor.cpp

@@ -26,6 +26,7 @@

#include "Dictionary.h"

#include "Frame.h"

#include "RuntimeEnabledFeatures.h"

+#include "ScriptController.h"

#include "V8Binding.h"

#include "V8DOMWrapper.h"

#include <wtf/UnusedParam.h>

@@ -147,6 +148,7 @@ static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestEventConstructorTempl

0, 0, isolate, currentWorldType);

UNUSED_PARAM(defaultSignature); // In some cases, it will not be used.

desc->SetCallHandler(V8TestEventConstructor::constructorCallback);

+ desc->SetLength(1);

// Custom toString template

desc->Set(v8::String::NewSymbol("toString"), V8PerIsolateData::current()->toStringTemplate());

« no previous file with comments | « Source/bindings/tests/results/V8TestCustomNamedGetter.cpp ('k') | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »