Source/bindings/tests/results/V8TestEventTarget.cpp - Issue 14244017: Make length property return useful values for DOM bindings functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 14244017: Make length property return useful values for DOM bindings functions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make length property return useful values for DOM bindings functions and interfaces Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/IDLParser.pm ('K') | « Source/bindings/tests/results/V8TestEventConstructor.cpp ('k') | Source/bindings/tests/results/V8TestMediaQueryListListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestEventTarget.cpp

diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp

index c653a1a4cd3a971cdbb456c374630ca1d81dcfed..8c5fbe4fea4baa4cc1735bf9ef7d2ed49c511e0e 100644

--- a/Source/bindings/tests/results/V8TestEventTarget.cpp

+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp

@@ -168,10 +168,10 @@ static v8::Handle<v8::Value> dispatchEventMethodCallback(const v8::Arguments& ar

} // namespace TestEventTargetV8Internal

static const V8DOMConfiguration::BatchedMethod V8TestEventTargetMethods[] = {

- {"item", TestEventTargetV8Internal::itemMethodCallback, 0},

- {"namedItem", TestEventTargetV8Internal::namedItemMethodCallback, 0},

- {"addEventListener", TestEventTargetV8Internal::addEventListenerMethodCallback, 0},

- {"removeEventListener", TestEventTargetV8Internal::removeEventListenerMethodCallback, 0},

+ {"item", TestEventTargetV8Internal::itemMethodCallback, 0, 1},

+ {"namedItem", TestEventTargetV8Internal::namedItemMethodCallback, 0, 1},

+ {"addEventListener", TestEventTargetV8Internal::addEventListenerMethodCallback, 0, 2},

+ {"removeEventListener", TestEventTargetV8Internal::removeEventListenerMethodCallback, 0, 2},

};

static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestEventTargetTemplate(v8::Persistent<v8::FunctionTemplate> desc, v8::Isolate* isolate, WrapperWorldType currentWorldType)