Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: dashboard/dashboard/mr.py

Issue 1424393003: Stop creating stoppage alerts once a group has reached a certain size. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/mr.py
diff --git a/dashboard/dashboard/mr.py b/dashboard/dashboard/mr.py
index 45bc363b006d8dbfec6b4b57f0ed282c41b053c1..4650b428c6dabd1d56a2b73a0e425ecc38635bc5 100644
--- a/dashboard/dashboard/mr.py
+++ b/dashboard/dashboard/mr.py
@@ -133,13 +133,17 @@ def _CreateStoppageAlerts(test, last_row):
warn_sheriff_delay_days = sheriff_entity.stoppage_alert_delay
if warn_sheriff_delay_days < 0:
return
-
now = datetime.datetime.now()
warn_sheriff_delta = datetime.timedelta(days=warn_sheriff_delay_days)
earliest_warn_time = now - warn_sheriff_delta
- if last_row.timestamp < earliest_warn_time:
- if not stoppage_alert.GetStoppageAlert(test.test_path, last_row.revision):
- yield op.db.Put(stoppage_alert.CreateStoppageAlert(test, last_row))
+ if last_row.timestamp >= earliest_warn_time:
+ return
+ if stoppage_alert.GetStoppageAlert(test.test_path, last_row.revision):
+ return
+ new_alert = stoppage_alert.CreateStoppageAlert(test, last_row)
+ if not new_alert:
+ return
+ yield op.db.Put(new_alert)
def _MarkDeprecated(test):

Powered by Google App Engine
This is Rietveld 408576698