Issue 1424393002: Constant cache improvement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1424393002: Constant cache improvement (Closed)

Created:
5 years, 1 month ago by hausner

Modified:
5 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Constant cache improvement Change the compile-time constant map to use a pair (url, token_pos) as the key. Previously, the two values were concatenated into a string, which creates a lot of new strings. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/f094c36141a422fd03352cf6b9e39ba52ff6861a

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -22 lines)			Patch
	M	runtime/vm/parser.cc	View	1	3 chunks	+47 lines, -22 lines	0 comments	Download

Total messages: 5 (2 generated)

hausner

5 years, 1 month ago (2015-11-02 18:59:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f094c36141a422fd03352cf6b9e39ba52ff6861a (presubmit successful).