Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1424363003: Remove two unncessary lines from jni_array.cc (Closed)

Created:
5 years, 1 month ago by Theresa
Modified:
5 years, 1 month ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove two unncessary lines from jni_array.cc Remove two unneeded lines from JNIArray's JavaArrayOfIntArrayToIntVector. BUG=529915 Committed: https://crrev.com/46b2f0f4321781596166937e7a1d554dabfbadb1 Cr-Commit-Position: refs/heads/master@{#357184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/android/jni_array.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Theresa
ptal - see discussion at the end of https://codereview.chromium.org/1337703002/ for more context if needed
5 years, 1 month ago (2015-10-30 18:33:05 UTC) #2
rmcilroy
Yup, this seems right, thansk for pointing it out Dimitri. Lgtm
5 years, 1 month ago (2015-10-30 18:36:12 UTC) #3
Dmitry Skiba
lgtm
5 years, 1 month ago (2015-10-30 18:49:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424363003/1
5 years, 1 month ago (2015-10-30 19:04:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 20:29:00 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 20:29:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46b2f0f4321781596166937e7a1d554dabfbadb1
Cr-Commit-Position: refs/heads/master@{#357184}

Powered by Google App Engine
This is Rietveld 408576698