Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1424353003: Don't allow hybrid assembler unless filetype=iasm. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/IceClFlags.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-10-30 15:34:02 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-10-30 19:08:06 UTC) #4
Karl
5 years, 1 month ago (2015-10-30 20:19:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e849a572f63e9fe948e15d1350275c24386b05d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698