Removes support for using the system clock on ChromeOS

Removes support for using the system clock on ChromeOS

As of http://crrev.com/1374753004, ChromeOS is able to use the monotonic
clock and still have its trace event timestamps match timestamps from
ftrace.

BUG=541692
Committed: https://crrev.com/71e0229785a02086d535024bd244ad69874ec2c3
Cr-Commit-Position: refs/heads/master@{#356994}

[charliea (OOO until 10-5), 2015-10-29 20:10:43]

charliea@chromium.org changed reviewers:
+ rickyz@chromium.org

[rickyz (no longer on Chrome), 2015-10-29 21:05:03]

lgtm with a nit, thanks!

https://codereview.chromium.org/1424323002/diff/1/sandbox/linux/seccomp-bpf-h...
File sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc
(right):

https://codereview.chromium.org/1424323002/diff/1/sandbox/linux/seccomp-bpf-h...
sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc:25:
#include "base/time/time.h"
Can this include be removed as well?

[charliea (OOO until 10-5), 2015-10-29 21:16:37]

https://codereview.chromium.org/1424323002/diff/1/sandbox/linux/seccomp-bpf-h...
File sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc
(right):

https://codereview.chromium.org/1424323002/diff/1/sandbox/linux/seccomp-bpf-h...
sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc:25:
#include "base/time/time.h"
On 2015/10/29 21:05:02, rickyz wrote:
> Can this include be removed as well?

Thanks for catching that! I was thinking that it couldn't because we were still
using the CLOCK_FOO constants, but those were actually coming from <time.h>

[charliea (OOO until 10-5), 2015-10-29 21:16:40]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2015-10-29 21:16:40]

The patchset sent to the CQ was uploaded after l-g-t-m from rickyz@chromium.org
Link to the patchset: https://codereview.chromium.org/1424323002/#ps20001
(title: "Code review")

[commit-bot: I haz the power, 2015-10-29 21:17:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424323002/20001

[charliea (OOO until 10-5), 2015-10-29 21:36:29]

The CQ bit was unchecked by charliea@chromium.org

[charliea (OOO until 10-5), 2015-10-29 21:50:28]

Patchset #3 (id:40001) has been deleted

[charliea (OOO until 10-5), 2015-10-29 21:53:06]

Hi Ricky,

PTAL. I realized that I forgot to update the unit tests for the file.

Retrieving a time with kClockSystemTrace should fail now on CHROME_OS, just like
any other operating system. I updated the test to reflect that by removing the
special clause for ChromeOS that makes it exempt from the normal Linux death
test. It's worth noting here that OS_CHROMEOS is a strict subset of OS_LINUX
(http://bit.ly/1WlUaU7).

But I have no idea what I'm doing, so if you could take a look to make sure I
did the right thing, it'd be greatly appreciated :)

[rickyz (no longer on Chrome), 2015-10-29 22:05:16]

lgtm

[charliea (OOO until 10-5), 2015-10-29 22:52:15]

The CQ bit was checked by charliea@chromium.org

[commit-bot: I haz the power, 2015-10-29 22:53:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424323002/60001

[commit-bot: I haz the power, 2015-10-30 00:07:43]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-10-30 00:08:36]

Patchset 3 (id:??) landed as
https://crrev.com/71e0229785a02086d535024bd244ad69874ec2c3
Cr-Commit-Position: refs/heads/master@{#356994}