Improve gn path command.

Improve gn path command.

Finds only non-data dependencies by default. A new flag is added to include these. Normally users are only interested in linked dependencies.

Adds a --public flag to print only public dependencies.

Sorts any output first by public-ness, then by length of the path. This generally matches what users are looking for.

Committed: https://crrev.com/c20901b3694df1dfcd5197f6baead231c48de07f
Cr-Commit-Position: refs/heads/master@{#358051}

[brettw, 2015-11-04 04:07:02]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2015-11-04 04:07:17]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 04:07:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424313009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424313009/20001

[commit-bot: I haz the power, 2015-11-04 04:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 04:21:06]

Dry run: This issue passed the CQ dry run.

[scottmg, 2015-11-04 22:01:21]

lgtm

https://codereview.chromium.org/1424313009/diff/20001/tools/gn/command_path.cc
File tools/gn/command_path.cc (right):

https://codereview.chromium.org/1424313009/diff/20001/tools/gn/command_path.c...
tools/gn/command_path.cc:95: bool IsAllPublic(const DepStack& stack) {
IsAllPublic sounds odd. AreAllPublic? IsCompletelyPublic? (Or not if you like
it.)

https://codereview.chromium.org/1424313009/diff/20001/tools/gn/command_path.c...
tools/gn/command_path.cc:210: "  --withdata\n"
Maybe --with-data since that's what you called the variable.

https://codereview.chromium.org/1424313009/diff/20001/tools/gn/command_path.c...
tools/gn/command_path.cc:212: "     private linked deps will be followed. Can'e
be used with --public.\n"
Can'e -> Can't.

https://codereview.chromium.org/1424313009/diff/20001/tools/gn/command_path.c...
tools/gn/command_path.cc:244:
base::CommandLine::ForCurrentProcess()->HasSwitch("withdata");
Check here that withdata/with-data/with_data and public_only aren't both set.

[brettw, 2015-11-05 13:54:51]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-11-05 13:54:51]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1424313009/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-11-05 13:55:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424313009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424313009/40001

[commit-bot: I haz the power, 2015-11-05 14:27:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-05 14:28:23]

Patchset 3 (id:??) landed as
https://crrev.com/c20901b3694df1dfcd5197f6baead231c48de07f
Cr-Commit-Position: refs/heads/master@{#358051}